Add functional test for resourceprovider registration (UDT) #8079

lakshmimsft · 2024-11-23T02:56:19Z

Description

-Update to Typespec for ResourceType, ResourceProviderSummary to update defaultApiVersion to be optional field.
-Added test for resourceprovider registration which includes calls to create, list and show resource provider.

Type of change

This pull request adds or changes features of Radius and has an approved issue (User-Defined Resource Types #6688 ).

Fixes: Part of #6688

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

radius-functional-tests · 2024-11-23T03:09:04Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`0aa8569`
Unique ID	func712b8858ce
Image tag	pr-func712b8858ce

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func712b8858ce
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func712b8858ce
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func712b8858ce
controller test image location: ghcr.io/radius-project/dev/controller:pr-func712b8858ce
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func712b8858ce
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-11-23T03:14:33Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`ed905fd`
Unique ID	func688b3fed0c
Image tag	pr-func688b3fed0c

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func688b3fed0c
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func688b3fed0c
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func688b3fed0c
controller test image location: ghcr.io/radius-project/dev/controller:pr-func688b3fed0c
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func688b3fed0c
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-11-23T04:15:40Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`37505b3`
Unique ID	func4301c1d27e
Image tag	pr-func4301c1d27e

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func4301c1d27e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func4301c1d27e
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func4301c1d27e
controller test image location: ghcr.io/radius-project/dev/controller:pr-func4301c1d27e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func4301c1d27e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-11-23T04:53:05Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`1917123`
Unique ID	func2b9d13eedc
Image tag	pr-func2b9d13eedc

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func2b9d13eedc
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func2b9d13eedc
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func2b9d13eedc
controller test image location: ghcr.io/radius-project/dev/controller:pr-func2b9d13eedc
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func2b9d13eedc
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>

radius-functional-tests · 2024-11-25T18:15:21Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`6f5c5f9`
Unique ID	funcaf7fd1cf22
Image tag	pr-funcaf7fd1cf22

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcaf7fd1cf22
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcaf7fd1cf22
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcaf7fd1cf22
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcaf7fd1cf22
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcaf7fd1cf22
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

ytimocin · 2024-11-25T18:20:55Z

typespec/UCP/resourceproviders.tsp

@@ -93,7 +93,7 @@ model ResourceTypeProperties {
  provisioningState?: ProvisioningState;

  @doc("The default api version for the resource type.")
-  defaultApiVersion: ApiVersionNameString;
+  defaultApiVersion?: ApiVersionNameString;


Might have missed this in the design doc, but would making this optional require code changes? Why? Because now resource type doesn't have a default API version, and the code needs to go and get it from somewhere else or throw an error?

For anyone else reviewing, this was a mistake in the initial .tsp. It was always supposed to be optional.

@ytimocin - you're making the assumption that anything reads this field. Nothing does yet.

ytimocin · 2024-11-25T18:22:32Z

test/functional-portable/ucp/noncloud/resourceprovider_test.go

+	output, err := cli.RunCommand(ctx, []string{"resource-provider", "list"})
+	require.NoError(t, err)
+	require.Contains(t, output, resourceProviderName)


Should this check for the size of the list?

This could be brittle due to crosstalk between tests.

ytimocin · 2024-11-25T18:23:42Z

test/functional-portable/ucp/noncloud/resourceprovider_test.go

+	require.Contains(t, output, resourceProviderName)
+
+	// Show details of the resource provider.
+	output, err = cli.RunCommand(ctx, []string{"resource-provider", "show", resourceProviderName, "--output", "json"})


Do we have a default resource provider as in if I run rad rp show would it show the default one? Just curious...

test/functional-portable/ucp/noncloud/resourceprovider_test.go

rynowak

lakshmimsft requested review from a team as code owners November 23, 2024 02:56

lakshmimsft temporarily deployed to publish-bicep November 23, 2024 02:57 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests November 23, 2024 03:07 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/rpregistrationtest branch from 0aa8569 to ed905fd Compare November 23, 2024 03:12

lakshmimsft temporarily deployed to publish-bicep November 23, 2024 03:12 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests November 23, 2024 03:13 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/rpregistrationtest branch from ed905fd to 37505b3 Compare November 23, 2024 04:11

lakshmimsft temporarily deployed to publish-bicep November 23, 2024 04:12 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests November 23, 2024 04:14 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/rpregistrationtest branch from 37505b3 to 1917123 Compare November 23, 2024 04:51

lakshmimsft temporarily deployed to functional-tests November 23, 2024 04:51 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to publish-bicep November 23, 2024 04:52 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/rpregistrationtest branch from 1917123 to e613a96 Compare November 25, 2024 16:59

lakshmimsft temporarily deployed to publish-bicep November 25, 2024 17:00 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/rpregistrationtest branch from e613a96 to 74e84e0 Compare November 25, 2024 17:03

lakshmimsft temporarily deployed to publish-bicep November 25, 2024 17:03 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/rpregistrationtest branch from 74e84e0 to 9f6f9d7 Compare November 25, 2024 17:20

lakshmimsft temporarily deployed to publish-bicep November 25, 2024 17:21 — with GitHub Actions Inactive

adding test

6f5c5f9

Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>

lakshmimsft force-pushed the lakshmimsft/rpregistrationtest branch from 9f6f9d7 to 6f5c5f9 Compare November 25, 2024 17:54

lakshmimsft temporarily deployed to publish-bicep November 25, 2024 17:55 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests November 25, 2024 18:14 — with GitHub Actions Inactive

ytimocin reviewed Nov 25, 2024

View reviewed changes

rynowak reviewed Nov 25, 2024

View reviewed changes

test/functional-portable/ucp/noncloud/resourceprovider_test.go Show resolved Hide resolved

rynowak approved these changes Nov 25, 2024

View reviewed changes

lakshmimsft merged commit 0aa2d6e into radius-project:main Nov 25, 2024
28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add functional test for resourceprovider registration (UDT) #8079

Add functional test for resourceprovider registration (UDT) #8079

lakshmimsft commented Nov 23, 2024

radius-functional-tests bot commented Nov 23, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 23, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 23, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 23, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 25, 2024 •

edited

Loading

ytimocin Nov 25, 2024

rynowak Nov 25, 2024

ytimocin Nov 25, 2024

rynowak Nov 25, 2024

ytimocin Nov 25, 2024

rynowak left a comment

Add functional test for resourceprovider registration (UDT) #8079

Add functional test for resourceprovider registration (UDT) #8079

Conversation

lakshmimsft commented Nov 23, 2024

Description

Type of change

Contributor checklist

radius-functional-tests bot commented Nov 23, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 23, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 23, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 23, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 25, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin Nov 25, 2024

Choose a reason for hiding this comment

rynowak Nov 25, 2024

Choose a reason for hiding this comment

ytimocin Nov 25, 2024

Choose a reason for hiding this comment

rynowak Nov 25, 2024

Choose a reason for hiding this comment

ytimocin Nov 25, 2024

Choose a reason for hiding this comment

rynowak left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Nov 23, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 23, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 23, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 23, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 25, 2024 •

edited

Loading