-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipes contribution guides #63
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
a8688d8
Fix container name (#58)
AaronCrawfis a59ab7d
Adding tags parameters with radapp defaults to Azure Recipes (#60)
willvelida f17aeac
Add contribution guides
Reshrahim 212a18b
Add contribution link
Reshrahim db03a55
Add contribution link
Reshrahim 33f86b3
Add links to contribution guides to code and PR
Reshrahim 35b2682
Rename contribution folder
Reshrahim 1630671
Add links to contribution guides to code and PR
Reshrahim c3cee52
Add testing steps
Reshrahim 64e21c8
Add testing steps
Reshrahim 6c6c4dc
close bicep code snippet
Reshrahim c58bece
Delete .DS_Store
Reshrahim d47207c
Address feedback
Reshrahim 0d56f54
Update docs/contributing/contributing-recipes.md
Reshrahim 48aee83
Address feedback
Reshrahim ef50556
Update publish in test workflow to exclude readme file)
Reshrahim 8cbb91a
Empty-Commit
Reshrahim 3a74109
Update aws/README.MD
Reshrahim bf440ae
Apply suggestions from code review
Reshrahim 57cfbe2
Address feedback
Reshrahim 88b096b
Address feedback
Reshrahim 04a99f7
Address feedback
Reshrahim a8f8913
Address feedback
Reshrahim 91fdac3
Add hyperlink
Reshrahim 88c3579
Add hyperlink
Reshrahim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,69 +1,18 @@ | ||
# Contribution Guidelines | ||
|
||
Thank you for your interest in Radius! | ||
Thank you for your interest in Recipes! We welcome contributions from the community. Contributions come in many forms: submitting issues, writing code, participating in discussions and community calls. | ||
|
||
This project has adopted the [Contributor Covenant Code of Conduct](https://github.com/radius-project/radius/blob/main/CODE-OF-CONDUCT.md). | ||
This document provides the guidelines for how to contribute to the recipes repository. | ||
|
||
Contributions come in many forms: submitting issues, writing code, participating in discussions and community calls. | ||
## Table of Contents | ||
|
||
This document provides the guidelines for how to contribute to the Radius project. | ||
|
||
## Issues | ||
|
||
This section describes the guidelines for submitting issues | ||
|
||
### Issue Types | ||
|
||
There are 2 types of issues: | ||
|
||
- bug: You've found a bug with the code, and want to report it, or create an issue to track the bug. | ||
- feature: Used for items that propose a new idea or functionality. This allows feedback from others before code is written. | ||
|
||
> For questions or feedback please refer to the [Radius Community docs](https://docs.radapp.dev/community/). Discord will be the best way to get in touch with the community and the maintainers. | ||
|
||
### Before You File | ||
|
||
Before you file an issue, make sure you've checked the following: | ||
|
||
1. Is it the right repository? | ||
- The Radius project is distributed across multiple repositories. Check the list of [repositories](https://github.com/radius-project) if you aren't sure which repo is the correct one. | ||
1. Check for existing issues | ||
- Before you create a new issue, please do a search in [open issues](https://github.com/radius-project/recipes/issues) to see if the issue or feature request has already been filed. | ||
- If you find your issue already exists, make relevant comments and add your [reaction](https://github.com/blog/2119-add-reaction-to-pull-requests-issues-and-comments). Use a reaction: | ||
- 👍 up-vote | ||
- 👎 down-vote | ||
1. For bugs | ||
- Check it's not an environment issue. For example, if running on Kubernetes, make sure prerequisites are in place. | ||
- Ensure you have as much data as possible. This usually comes in the form of logs and/or stacktrace. If running on Kubernetes or other environment, look at the logs of the Radius services (UCP, RP, DE). More details on how to get logs can be found [here](https://docs.radapp.dev/reference/troubleshooting-radius/). | ||
1. For proposals | ||
- Many changes to the Radius runtime may require changes to the API. In that case, the best place to discuss the potential feature is the main [Radius repo](https://github.com/radius-project/radius). | ||
- Recipes runtime changes can be discussed in the [Radius repo](https://github.com/radius-project/radius). | ||
- Community Recipes can be discussed within [this repo](https://github.com/radius-project/recipes/issues). | ||
|
||
## Contributing to Radius Recipes | ||
|
||
This section describes the guidelines for contributing code / docs to Radius Recipes. | ||
|
||
### Prerequisites | ||
|
||
Make sure you are familiar with how to author and test Recipes. The [custom Recipes docs](https://docs.radapp.io/guides/recipes/howto-author-recipes/) will walk you through the process. Make sure to test with your own registry and environment before submitting a PR. | ||
|
||
### Pull Requests | ||
|
||
All contributions come through pull requests. To submit a proposed change, we recommend following this workflow: | ||
|
||
1. Make sure there's an issue (bug or feature) raised, which sets the expectations for the contribution you are about to make. | ||
1. Fork the relevant repo and create a new branch | ||
1. Create your change | ||
1. Update relevant documentation for the change | ||
1. Commit and open a PR | ||
1. Wait for the CI process to finish and make sure all checks are green | ||
1. A maintainer of the repo will be assigned, and you can expect a review within a few days | ||
|
||
#### Use work-in-progress PRs for early feedback | ||
|
||
A good way to communicate before investing too much time is to create a draft PR and share it with your reviewers. The standard way of doing this is to mark your PR as draft within GitHub. | ||
- [Contributing to Radius Recipes](docs/contributing/contributing-recipes.md) : This guide provides an overview of how to write your own recipes and contribute to the community. | ||
- [Contributing Issues](docs/contributing/contributing-issues.md) : This guide provides an overview of how to contribute issues to the Recipes. | ||
|
||
## Thank You! | ||
|
||
Your contributions to open source, large or small, make projects like this possible. Thank you for taking the time to contribute. | ||
|
||
## Code of Conduct | ||
|
||
Please refer to our [Radius Community Code of Conduct](https://github.com/radius-project/radius/blob/main/CODE_OF_CONDUCT.md) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# AWS Recipes | ||
|
||
The [aws](/aws) directory contains Recipes for AWS resources. They are configurable via parameters, with the default values optimizing for cost and security. | ||
|
||
## Available Recipes | ||
|
||
| Recipe | Resource | Description | Template Path | | ||
|--------|----------|-------------|---------------| | ||
| [`aws/rediscaches`](/aws/rediscaches.bicep) | `Applications.Datastores/redisCaches` | An AWS MemoryDB resource with a configurable size and SKU. | `ghcr.io/radius-project/recipes/aws/rediscaches:TAG` | | ||
| [`aws/sqldatabases`](/aws/sqldatabases.bicep) | `Applications.Datastores/sqlDatabases` | An AWS RDS resource with a configurable size and SKU. | `ghcr.io/radius-project/recipes/aws/sqldatabases:TAG` | | ||
|
||
You can also contribute your own AWS recipes for the supported resource types and IaC languages. Visit the [contributions guide](/contributing/contributing-recipes.md) to learn how to write your own recipes and contribute to the community. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
## Azure recipes | ||
|
||
The [azure](/azure) directory contains Recipes for Azure resources. They are configurable via parameters, with the default values optimizing for cost and security. | ||
|
||
## Available Recipes | ||
|
||
| Recipe | Resource | Description | Template Path | | ||
|--------|----------|-------------|---------------| | ||
| [`azure/rediscaches`](/azure/rediscaches.bicep) | `Applications.Datastores/redisCaches` | An Azure Cache for Redis resource with a configurable size and SKU. | `ghcr.io/radius-project/recipes/azure/rediscaches:TAG` | | ||
| [`azure/sqldatabases`](/azure/sqldatabases.bicep) | `Applications.Datastores/sqlDatabases` | An Azure SQL server resource with a configurable size and SKU. | `ghcr.io/radius-project/recipes/azure/sqldatabases:TAG` | | ||
| [`azure/statestores`](/azure/statestores.bicep) | `Applications.Dapr/stateStores` |An Azure blob storage state store. | `ghcr.io/radius-project/recipes/azure/statestores:TAG` | | ||
|
||
You can also contribute your own Azure recipes for the supported resource types and IaC languages. Visit the [contributions guide](/contributing/contributing-recipes.md) to learn how to write your own recipes and contribute to the community. | ||
|
||
## Tags | ||
|
||
1. For Azure recipes, make sure to add tags to the recipe to indicate the infrastructure deployed by Recipes is created by Radius. For example: | ||
|
||
```bicep | ||
@description('The user-defined tags that will be applied to the resource. Default is null') | ||
param tags object = {} | ||
|
||
@description('The Radius specific tags that will be applied to the resource') | ||
var radiusTags = { | ||
'radapp.io-environment': context.environment.id | ||
'radapp.io-application': context.application == null ? '' : context.application.id | ||
'radapp.io-resource': context.resource.id | ||
} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,9 +40,20 @@ param skuFamily string = 'C' | |
]) | ||
param skuName string = 'Basic' | ||
|
||
@description('The user-defined tags that will be applied to the resource. Default is null') | ||
param tags object = {} | ||
|
||
@description('The Radius specific tags that will be applied to the resource') | ||
var radiusTags = { | ||
'radapp.io-environment': context.environment.id | ||
'radapp.io-application': context.application == null ? '' : context.application.id | ||
'radapp.io-resource': context.resource.id | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this pattern be documented somewhere? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added this to the README in /azure directory |
||
resource azureCache 'Microsoft.Cache/redis@2022-06-01' = { | ||
name: 'cache-${uniqueString(context.resource.id, resourceGroup().id)}' | ||
location: location | ||
tags: union(tags, radiusTags) | ||
properties: { | ||
sku: { | ||
capacity: skuCapacity | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we say more here? I'd like to say more about the background of how we're organizing these. If I want to contribute something, how can I figured out where it fits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some details on the structure of the folder.