Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Applications.Dapr/configurationStores local-dev recipe #75

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

SoTrx
Copy link
Contributor

@SoTrx SoTrx commented Sep 17, 2024

Hey,

This PR introduces a local-dev recipe for Applications.Dapr/configurationStores

It is related to:

The prerequisite for this PR is Radius pull request, which has now been merged. A new type, Application.Dapr/configurationStores, was introduced in the radius repo and will be recognized by the test workflow running against current PR in the recipes repo.

Signed-off-by: SoTrxII <11771975+SoTrx@users.noreply.github.com>
@SoTrx SoTrx requested review from a team as code owners September 17, 2024 11:24
@Reshrahim
Copy link
Contributor

@SoTrx - Thanks for the contribution. The new recipe should be added to the readme - https://github.com/radius-project/recipes/blob/main/local-dev/README.md

Signed-off-by: SoTrxII <11771975+SoTrx@users.noreply.github.com>
Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SoTrx. This is great!

@willtsai, @Reshrahim - General question, not directly impacted by this or blocking for this PR but wanted to bring this up now since it adds another dapr recipe. Do we want to organize dapr recipes under a subdirectory or rename the files to be more explicit? I wonder if configurationstore.bicep, statestore.bicep can be confusing without looking at the code.

@Reshrahim
Copy link
Contributor

Thanks @SoTrx. This is great!

@willtsai, @Reshrahim - General question, not directly impacted by this or blocking for this PR but wanted to bring this up now since it adds another dapr recipe. Do we want to organize dapr recipes under a subdirectory or rename the files to be more explicit? I wonder if configurationstore.bicep, statestore.bicep can be confusing without looking at the code.

I guess we can include the prefix dapr to the naming convention to avoid confusion e.g.daprconfigurationstore.bicep. When we enable UDT's, I expect us to do some changes on the directory structure across the board.

@lakshmimsft lakshmimsft changed the title Add Applications.Dapr/ConfigurationStores local-dev recipe Add Applications.Dapr/configurationStores local-dev recipe Sep 26, 2024
@lakshmimsft lakshmimsft merged commit 1afbd9f into radius-project:main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants