Skip to content

Conversation

shivg7795
Copy link

No description provided.

@Reshrahim
Copy link
Contributor

Hi @shivg7795 – Thanks for contributing the ACI Recipes!

I just published the contribution guidelines, which outlines the repo structure and the requirements for contributing a Resource Type and Recipe. When you get a chance, could you review the guidelines and update your PR to align with them?

If you run into any gaps or have suggestions, feel free to open an issue or a PR..we’d love your feedback!

@sk593
Copy link
Contributor

sk593 commented Aug 7, 2025

Thanks for the contributions @shivg7795! Radius only deploys Bicep and Terraform templates so we can remove the ARM templates for now. I'll leave additional recipe-specific comments in line

@shivg7795 shivg7795 requested review from a team as code owners August 19, 2025 01:21
@willtsai
Copy link
Contributor

@shivg7795 - can you please also update the directory and file structure per this previous comment: #3 (comment)

There should be more details now on the contribution guide describing the file structure.

Thanks!

@willtsai
Copy link
Contributor

couple things to note following our offline discussion:

  1. The basic and confidential container implementations should be in a single Recipe. Radius will pass along a couple things as context for the logic implemented in the Recipe to decide on what to provision: an allowPlatformOptions boolean and a platformOptions.aci: {} object. See user story 4 for more details.
  2. There needs to be a volumes Recipe created to provision storage resources that can be mounted to the container as a volume, see user story 10 for more details.
  3. The load balancer (or whatever is needed to implement L4 networking between containers) provisioning should be built directly into the containers Recipe and not as a separate Recipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants