-
Notifications
You must be signed in to change notification settings - Fork 11
Add MongoDB Resource Type and Kubernetes Terraform Recipe #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add MongoDB Resource Type and Kubernetes Terraform Recipe #51
Conversation
…etes Recipe (radius-project#21) Signed-off-by: Panagiotis Bellias <belliaspan@gmail.com>
Signed-off-by: Panagiotis Bellias <belliaspan@gmail.com>
Signed-off-by: Panagiotis Bellias <belliaspan@gmail.com>
Signed-off-by: Panagiotis Bellias <belliaspan@gmail.com>
Signed-off-by: Panagiotis Bellias <belliaspan@gmail.com>
Signed-off-by: Panagiotis Bellias <belliaspan@gmail.com>
Signed-off-by: Panagiotis Bellias <belliaspan@gmail.com>
Signed-off-by: Panagiotis Bellias <belliaspan@gmail.com>
Signed-off-by: Panagiotis Bellias <belliaspan@gmail.com>
…ject#21) Signed-off-by: Panagiotis Bellias <belliaspan@gmail.com>
…ject#21) - mongodb.yaml schema - Terraform recipe (main.tf, variables.tf, outputs.tf) - README.md with usage instructions and manual testing notes Signed-off-by: Panagiotis Bellias <belliaspan@gmail.com>
02f02f0
to
2b85e6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panagiotisbellias - Thanks for your interest in contributing!
Some high level thoughts:
- This repository follows a structure and pattern to organize and structure the resource-type definitions and Recipes. Please read the contributions guidelines thoroughly and make sure to follow the exact repository structure and naming conventions .
- Checkout the tutorial on Resource types -https://docs.radapp.io/tutorials/create-resource-type/ to understand how Resource types and Recipes work together.
- Resource type schema must follow the required metadata properties we use across other resource types (naming, descriptions, API versions). Please align it with existing schemas in the repo.
- Checkout the guide on How to Author Recipes to adhere to the structure
- README's should follow the exact structure as defined in the guidelines as they serve as the guidance for platform engineers
- For an alpha stage contribution, no automated test is required. Submit manual testing evidence following this https://github.com/radius-project/resource-types-contrib/blob/main/docs/contributing/testing-resource-types-recipes.md
Let me know if you need help with this. Would be happy to chat 1:1 as well in Discord.
@@ -0,0 +1,68 @@ | |||
name: Test MongoDB Recipe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A GH workflow to test only the mongo type is not required and a manual evidence of testing is enough for alpha level contribution. Please review the testing guidelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I remove it but have no available environment to run terraform right now and I won't test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on the feedback here. I’ve reviewed the schema definition and added a few suggestions.
Think of the schema as the interface that developers will use in their application definitions, and the Recipes as the implementation of that interface. The schema should remain as generic as possible, without Kubernetes-specific properties, while the Recipes handle the platform-specific details.
This PR introduces a new MongoDB resource type schema and an associated Kubernetes recipe using Terraform. It fully implements the requirements from GitHub Issue #21.
Changes included:
Manual Testing Results:
Usage in Real Environments:
Closes #21