Remove httpRoutes from samples #574

nithyatsu · 2023-09-18T20:52:09Z

rewrite eshop and eshop dapr using the http-route-less model radius can support now. Summary of changes

"containers" with ports will create services with the same name
"connections" will support url based destination (protocol://servicename:port) instead of the earlier routeName.id format

The new envoy image is pushed to ghcr. This image had to be edited since the "routes" of gateway is changed to reflect the new names of services. Service names now match the name of the container offering the service. (ref: /radius/samples/reference-apps/eshop/envoy/README.md)

This PR partially fixes: radius-project/radius#6099

rynowak · 2023-09-27T18:22:47Z

quickstarts/dapr/dapr-azure.bicep

 resource gateway 'Applications.Core/gateways@2023-10-01-preview' = {
  name: 'gateway'
  properties: {
    application: app.id
    routes: [
      {
        path: '/'
-        destination: frontendRoute.id
+        destination: 'http://frontend:80'


It's conventional to omit the 80 when using HTTP since 80 is considered the default port for HTTP (like 443 for HTTPS). Can you update these to look like http://frontend instead?

reference-apps/container-app-store/iac/infra-selfhosted.bicep

reference-apps/eshop/envoy/envoy copy.yaml.txt

willdavsmith · 2023-09-28T13:11:18Z

reference-apps/eshop/iac/services/webshopping.bicep

@@ -119,15 +86,15 @@ resource webshoppingapigw 'Applications.Core/containers@2023-10-01-preview' = {
  properties: {
    application: application
    container: {
-      image: 'radius.azurecr.io/eshop-envoy:0.1.4'
+      image: 'nitcr.azurecr.io/eshop-envoy:0.1.100'


do we need to push a new image to radius cr?

yes, was waiting for the changes to look good, so that I can push the new image to radisu cr.

vinayada1 · 2023-11-08T19:42:33Z

samples/eshop-dapr/services/catalog-api.bicep

@@ -67,12 +54,11 @@ resource catalogApi 'Applications.Core/containers@2023-10-01-preview' = {
        ASPNETCORE_ENVIRONMENT: 'Development'
        ASPNETCORE_URLS: 'http://0.0.0.0:80'
        RetryMigrations: 'true'
-        SeqServerUrl: seqRoute.properties.url
+        SeqServerUrl: 'http://seq:5340'


Is there a way to remove this hardcoding?

Applies to all hardcoded strings

The hardcoding comes as part of using DNS-SD and conventionally making the name of service = name of container. @rynowak had suggested to look at it as the DNS hostname of service, instead of a typical hardcoded value.

This is desirable hardcoding 👍

AaronCrawfis · 2023-11-08T21:17:29Z

I'm getting an error when checking out:

AaronCrawfis

Unable to run eshop sample on AKS

nithyatsu · 2023-11-08T21:48:02Z

Unable to run eshop sample on AKS

was working when I had made the changes long back :( will take a look.

nithyatsu · 2023-11-14T17:49:04Z

It is because the envoy image in ghcr needed to be updated with the contents in this PR.

Completed            payment         Microsoft.Resources/deployments
Completed            web             Microsoft.Resources/deployments
Completed            webhooks        Microsoft.Resources/deployments
.                    identity        Microsoft.Resources/deployments
.                    catalog         Microsoft.Resources/deployments
.                    catalog-api     Applications.Core/containers
Completed            gateway         Applications.Core/gateways
.                    identity-api    Applications.Core/containers
.                    ordering-backgroundtasks Applications.Core/containers
Completed            ordering-signalrhub Applications.Core/containers
Completed            ordering-api    Applications.Core/containers
.                    basket-api      Applications.Core/containers

Deployment Complete

Resources:
    eshop           Applications.Core/applications
    basket-api      Applications.Core/containers
    catalog-api     Applications.Core/containers
    identity-api    Applications.Core/containers
    ordering-api    Applications.Core/containers
    ordering-backgroundtasks Applications.Core/containers
    ordering-signalrhub Applications.Core/containers
    payment-api     Applications.Core/containers
    seq             Applications.Core/containers
    web-spa         Applications.Core/containers
    webhooks-api    Applications.Core/containers
    webhooks-client Applications.Core/containers
    webmvc          Applications.Core/containers
    webshoppingagg  Applications.Core/containers
    webshoppingapigw Applications.Core/containers
    webstatus       Applications.Core/containers
    servicebus      Applications.Core/extenders
    gateway         Applications.Core/gateways
    basket-data     Applications.Datastores/redisCaches
    keystore-data   Applications.Datastores/redisCaches
    catalogdb       Applications.Datastores/sqlDatabases
    identitydb      Applications.Datastores/sqlDatabases
    orderingdb      Applications.Datastores/sqlDatabases
    webhooksdb      Applications.Datastores/sqlDatabases
    rabbitmq        Applications.Messaging/rabbitMQQueues

Public Endpoints:
    gateway         Applications.Core/gateways unknown

Will test it on an aks in order to get a public IP next.

nithyatsu · 2023-11-14T18:54:53Z

OK, got it to work, please review when you get a chance. @AaronCrawfis @willdavsmith

ytimocin · 2023-11-15T19:53:53Z

playwright/tests/eshop/eshop.app.spec.ts

@@ -30,7 +30,7 @@ test("eShop on Containers App Basic UI and Functionality Checks", async ({ page
  await page.getByText("LOGIN").click();

  // Expect page to have proper title
-  expect(page).toHaveTitle("eShopOnContainers - Identity");
+  // expect(page).toHaveTitle("eShopOnContainers - Identity");


Why was this commented out?

for a test, now reverted back.

ytimocin · 2023-11-15T19:55:19Z

samples/eshop/src/envoy/README.md

@@ -10,5 +10,5 @@ To build the docker image, run `docker build . -t ghcr.io/radius-project/samples

 Where NUMBER is one greater than the latest version made. To view versions, see https://ms.portal.azure.com/#view/Microsoft_Azure_ContainerRegistries/RepositoryBlade/id/%2Fsubscriptions%2F66d1209e-1382-45d3-99bb-650e6bf63fc0%2FresourceGroups%2Fassets%2Fproviders%2FMicrosoft.ContainerRegistry%2Fregistries%2Fradius/repository/eshop-envoy.

-To push the image, run `az acr login -n radius` and then `docker push ghcr.io/radius-project/samples/eshop-envoy:0.1.<NUMBER>`.
+To push the image, run `az acr login -n radius` and then `docker push ghcr.io/radius-project/samples/eshop/eshop-envoy:0.1.<NUMBER>`.


Was this wrong before?

Yes, the readme was wrong since all assets related to eshop are in the corrected path.

ytimocin · 2023-11-15T19:55:33Z

.DS_Store

should be deleted

samples/eshop/app.bicep

github-actions · 2024-03-05T18:00:47Z

This pull request has been automatically marked as stale because it has been inactive for 90 days. Remove stale label or comment or this PR will be closed in 7 days.

rynowak · 2024-03-10T00:29:12Z

@nithyatsu @AaronCrawfis @willtsai - what's still needed here? I can dig in and help if we're stuck. It's hurting us in other places to maintain the httpRoute code and eShop is the only place it's used (besides generated docs).

nithyatsu · 2024-03-12T02:54:32Z

@rynowak it just needs some priority so that both PM team and I can work on it/ test it to get it merged.
There aren't any tech difficulties (that I know of)

rynowak · 2024-03-12T02:58:56Z

If the tests are passing can we merge it? @AaronCrawfis do you have feedback that we need to address?

nithyatsu force-pushed the remoteroutes branch from 838f40d to d985c88 Compare September 26, 2023 17:51

nithyatsu marked this pull request as ready for review September 26, 2023 21:01

nithyatsu requested a review from a team as a code owner September 26, 2023 21:01

rynowak reviewed Sep 27, 2023

View reviewed changes

reference-apps/container-app-store/iac/infra-selfhosted.bicep Outdated Show resolved Hide resolved

willdavsmith reviewed Sep 28, 2023

View reviewed changes

nithyatsu force-pushed the remoteroutes branch from 134d97b to 1f0fc68 Compare October 17, 2023 16:56

nithyatsu requested review from rynowak, willdavsmith and AaronCrawfis October 18, 2023 19:13

nithyatsu force-pushed the remoteroutes branch from 1f0fc68 to 27efc92 Compare November 3, 2023 17:02

vinayada1 reviewed Nov 8, 2023

View reviewed changes

AaronCrawfis changed the title ~~Update samples to remove httpRoutes since services can now be deployed as part of container rendering~~ Remove httpRoutes from samples Nov 8, 2023

AaronCrawfis suggested changes Nov 8, 2023

View reviewed changes

nithyatsu force-pushed the remoteroutes branch from 27efc92 to 88c5256 Compare November 13, 2023 22:27

nithyatsu requested review from AaronCrawfis and willtsai November 15, 2023 17:46

ytimocin reviewed Nov 15, 2023

View reviewed changes

nithyatsu added 8 commits November 29, 2023 10:38

sdf

c1ef438

sdf

f1ac5b4

wip

11adbaa

wip

b1afc80

wip

3033a92

version change + envoy changes

208eb51

update eshop dapr to work without httproutes

fd22d86

rely on default http port

22ca62a

nithyatsu added 9 commits November 29, 2023 10:38

remove ununsed params

a014621

path edits

1f71c70

test

7deac03

de

8279eb5

sc

12f873b

qwef

5353130

add healthprobes

166dfd2

wip

8c0e98b

wip

6b103e0

nithyatsu force-pushed the remoteroutes branch from 3e3c1f4 to 6b103e0 Compare November 29, 2023 18:43

remove local files

bb45fd6

AaronCrawfis reviewed Dec 1, 2023

View reviewed changes

samples/eshop/app.bicep Outdated Show resolved Hide resolved

nithyatsu added 3 commits December 1, 2023 15:30

delete local files

69f7fc9

change to tcp probe for pods that dont support http

521f2cb

nit

2ad9be0

willtsai mentioned this pull request Feb 1, 2024

Clean up Route resources from codebase radius-project/radius#6099

Closed

github-actions bot added the stale label Mar 5, 2024

Merge branch 'edge' into remoteroutes

6ef2a97

github-actions bot removed the stale label Mar 10, 2024

AaronCrawfis approved these changes Mar 12, 2024

View reviewed changes

AaronCrawfis merged commit 90b7f98 into edge Mar 12, 2024
8 checks passed

AaronCrawfis deleted the remoteroutes branch March 12, 2024 16:48

youngbupark mentioned this pull request Apr 3, 2024

[Regression] Improve reliability for DNS-SD change #1040

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove httpRoutes from samples #574

Remove httpRoutes from samples #574

nithyatsu commented Sep 18, 2023 •

edited

Loading

rynowak Sep 27, 2023 •

edited

Loading

nithyatsu Oct 17, 2023

willdavsmith Sep 28, 2023

nithyatsu Oct 12, 2023

vinayada1 Nov 8, 2023

vinayada1 Nov 8, 2023

nithyatsu Nov 8, 2023

rynowak Mar 12, 2024

AaronCrawfis commented Nov 8, 2023 •

edited

Loading

AaronCrawfis left a comment

nithyatsu commented Nov 8, 2023

nithyatsu commented Nov 14, 2023

nithyatsu commented Nov 14, 2023

ytimocin Nov 15, 2023

nithyatsu Nov 16, 2023

ytimocin Nov 15, 2023

nithyatsu Nov 16, 2023

ytimocin Nov 15, 2023

github-actions bot commented Mar 5, 2024

rynowak commented Mar 10, 2024

nithyatsu commented Mar 12, 2024

rynowak commented Mar 12, 2024

Remove httpRoutes from samples #574

Remove httpRoutes from samples #574

Conversation

nithyatsu commented Sep 18, 2023 • edited Loading

rynowak Sep 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AaronCrawfis commented Nov 8, 2023 • edited Loading

AaronCrawfis left a comment

Choose a reason for hiding this comment

nithyatsu commented Nov 8, 2023

nithyatsu commented Nov 14, 2023

nithyatsu commented Nov 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 5, 2024

rynowak commented Mar 10, 2024

nithyatsu commented Mar 12, 2024

rynowak commented Mar 12, 2024

nithyatsu commented Sep 18, 2023 •

edited

Loading

rynowak Sep 27, 2023 •

edited

Loading

AaronCrawfis commented Nov 8, 2023 •

edited

Loading