-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider Thumb primitives not working in Preact #1601
Comments
Hi @nikuda, thanks for raising. Honestly I feel like this would be best solved at the Preact level and would encourage you to raise an issue there. While I understand and appreciate the goals of that project, Radix uses a wide array of React features and we can't guarantee functional behaviour if this implementation differs under the hood. For that reason I'm going to close this for now, feel free to follow up with more information though if you learn more as relates to Preact specifically 🙏 |
Not a problem @andy-hook. Raised the issue in preact repo preactjs/preact#3666. There's a fair bit of cross-over between Preact and Radix UI: lightweight, focused libraries. Would you be open to having some kind of compatibility suite once the issues are ironed out? |
Thanks @nikuda
Honestly unlikely, creating style agnostic, a11y enhanced primitives just for the React target is challenging enough at the best of times. If React decides to move away from a synthetic event system in the future then parity may increase and make this easier though. |
SliderPrimitive.Thumb が適切に動作しない ([radix-ui 側の issue](radix-ui/primitives#1601)) ([preact 側の issue](preactjs/preact#3666))
Bug report
Current Behavior
Thumb components are not shown, and not receiving any updates pass the initial inline style applied:
If the nested span's css is modified from
display: none
todisplay: block
the element is rendered on left edge and still doesn't move despite the white line being draggable on both ends.Expected behavior
For slider thumbs to be attached to end of white line and to move along with them.
Reproducible example
https://stackblitz.com/edit/nextjs-preact-webpack5-pjoxwh
Additional context
With Preact
v10.10.1
release Slider component no longer hangs the whole app, and for most past it works except for the Thumb components as described above.Your environment
@radix-ui/react-slider
1.0.0
10.10.1
91.0
16.14.2
yarn
1.22.10
The text was updated successfully, but these errors were encountered: