[Slider] Prevent default for Home and End keys

[luisorbaiceta]

Closes #1054

Description

As titled

[jjenzz]

@luisorbaiceta there is a bit of a gotcha with our versioning 🙈

Can you run it again and deny the workspace please? We should probably update our contributing docs tbh. Sorry about that.

[luisorbaiceta]

No problem! 👍

[luisorbaiceta]

For some reason I don't seem to have access to CHROMATIC_PROJECT_TOKEN 🤷‍♂️ Is this expected?

[jjenzz]

@luisorbaiceta Yep, but to be honest I wouldn't expect your change to cause any visual regressions.

@andy-hook @benoitgrelard Shall we just merge this or think it's worth doing our usual PR branching dance still?

[luisorbaiceta]

@luisorbaiceta Yep, but to be honest I wouldn't expect your change to cause any visual regressions.

Will this change in the future? I'm planning to spend time in the long term contributing to this project

[andy-hook]

Shall we just merge this or think it's worth doing our usual PR branching dance still?

@jjenzz I’d prefer if we stayed consistent tbh, inconvenient as it is 😅

I'm planning to spend time in the long term contributing to this project

@luisorbaiceta That's great!

Will this change in the future?

Do you mean access to secrets in code forked PRs?

[luisorbaiceta]

Do you mean access to secrets in code forked PRs?

A way to check if changes have visual regressions. Chromatic suggests this:

Don't know if this is convenient though...

[jjenzz]

@luisorbaiceta I've just merged a PR which should fix all this. Would you mind pulling latest from main and pushing your branch again so we can see if it all works okay? 🙏

[luisorbaiceta]

Sure! Done @jjenzz

[jjenzz]

Thanks @luisorbaiceta , you should be able to see this in the next release candidate shortly 🎉