[ScrollArea] Viewport fixes #2945
Merged
+198
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladmoroz
requested review from
StephenHaney,
lucasmotta and
hadihallak
as code owners
vladmoroz
commented
Jun 10, 2024
Comment on lines
+1038
to
+1057
| /** | ||
| * This is a helper function that is used when a component supports `asChild` | ||
| * using the `Slot` component but its implementation contains nested DOM elements. | ||
| * | ||
| * Using it ensures if a consumer uses the `asChild` prop, the elements are in | ||
| * correct order in the DOM, adopting the intended consumer `children`. | ||
| */ | ||
| function getSubtree( | ||
| options: { asChild: boolean | undefined; children: React.ReactNode }, | ||
| content: React.ReactNode | ((children: React.ReactNode) => React.ReactNode) | ||
| ) { | ||
| const { asChild, children } = options; | ||
| if (!asChild) return typeof content === 'function' ? content(children) : content; | ||
|
|
||
| const firstChild = React.Children.only(children) as React.ReactElement; | ||
| return React.cloneElement(firstChild, { | ||
| children: typeof content === 'function' ? content(firstChild.props.children) : content, | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
We worked this out in radix-ui/themes#311
|
Any progress on this? I just hit this issue today... |
|
Any progress on this too... |
|
Same here, have tmp fix, but need proper |
Closed
2 tasks
chaance
approved these changes
Aug 10, 2024
|
thank you so much folks 🙏 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asChildprop not working as expected on the Viewport partdisplay: tablewith flex styles on the parent that allow the viewport to fill container height (based on the Radix Themes implementation)[data-radix-scroll-area-content]text-overflow: ellipsisnot working when used with a vertical scrollbarCloses #926 #1666