Segmented control: Support disabled prop
#621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chaance
reviewed
Oct 30, 2024
| @@ -20,6 +20,12 @@ | |||
|
|
|||
| /* Create a new stacking context */ | |||
| isolation: isolate; | |||
|
|
|||
| &.disabled { | |||
There was a problem hiding this comment.
Should we use :where or is the added specificity useful here?
Suggested change
| &.disabled { | |
| &:where(.disabled) { |
There was a problem hiding this comment.
The specificity is needed here to override the color and background-color on the base class.
chaance
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend
SegmentedControlto supportdisabledfunctionality and style. In this implementation bothclassicandsurfacevariants share the same disabled styles. See design spec and context for request.Testing steps
Visit the sink page in the playground to see the disabled control.
Relates issues / PRs