fix sideEffects declaration
#659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the current
sideEffects: falsedeclaration, webpack drops CSS files from the build completely. The lineimport "@radix-ui/themes/styles.css";does not have any effectMore details in the webpack issue: webpack/webpack#6571
Also, the declaration need to propagate to the inner file in the
/esmsubfolder. Without that, every new package.json in a way assumes side effects by defaultTesting steps
Patched locally, it works.
No differences found when using Vite
Relates issues / PRs
A bunch PRs to other libraries with the same fix