This repository was archived by the owner on Feb 19, 2024. It is now read-only.
Transaction History #163
Merged
Transaction History #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sajjon
reviewed
Apr 6, 2021
There was a problem hiding this comment.
Big PR :D, overall LGTM! I did not read it carefully and mostly looked at tests for transactionHistory, but looked about right! I think I only saw one test containing one one action, of type Other, I would maybe have included one test for tx with single TransferTokens action, one test for single StakeTokens and one for single UnstakeTokens and maybe one test for a tx with multiple actions, but that is up to you and network team :)
Beautiful code, as always 😍
radixdlt-core/radixdlt/src/main/java/com/radixdlt/client/ClientApiUtils.java
Show resolved
Hide resolved
radixdlt-core/radixdlt/src/main/java/com/radixdlt/client/store/MessageEntry.java
Show resolved
Hide resolved
radixdlt-core/radixdlt/src/test/java/org/radix/api/jsonrpc/HighLevelApiHandlerTest.java
Show resolved
Hide resolved
talekhinezh
suggested changes
Apr 7, 2021
...t-core/radixdlt/src/main/java/com/radixdlt/client/store/berkeley/BerkeleyClientApiStore.java
Outdated
Show resolved
Hide resolved
...t-core/radixdlt/src/main/java/com/radixdlt/client/store/berkeley/BerkeleyClientApiStore.java
Show resolved
Hide resolved
...t-core/radixdlt/src/main/java/com/radixdlt/client/store/berkeley/BerkeleyClientApiStore.java
Outdated
Show resolved
Hide resolved
...lt-core/radixdlt/src/test/java/com/radixdlt/client/store/berkeley/TransactionParserTest.java
Outdated
Show resolved
Hide resolved
...lt-core/radixdlt/src/test/java/com/radixdlt/client/store/berkeley/TransactionParserTest.java
Outdated
Show resolved
Hide resolved
radixdlt-java-common/src/main/java/com/radixdlt/crypto/ECDSASignature.java
Outdated
Show resolved
Hide resolved
siy
force-pushed
the
feature/rpnv1-1137-executed-transactions
branch
from
a887aba to
976e49f
Compare
siy
force-pushed
the
feature/rpnv1-1137-executed-transactions
branch
from
976e49f to
6f20fda
Compare
LukasGasior1
approved these changes
Apr 8, 2021
talekhinezh
approved these changes
Apr 8, 2021
|
SonarCloud Quality Gate failed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.