This repository has been archived by the owner on Feb 19, 2024. It is now read-only.
Use uncompressed representation for ECPublicKey equality #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasGasior1
commented
Apr 15, 2021
| @@ -52,7 +52,7 @@ public void when_an_address_is_created_with_same_string__they_should_be_equal_an | |||
|
|
|||
| @Test | |||
| public void address_from_key_and_magical() throws PublicKeyException { | |||
| String publicKeyHexString = "03000102030405060708090A0B0C0D0E0F101112131415161718191A1B1C1D1E1F"; | |||
There was a problem hiding this comment.
changed because these bytes didn't represent a valid ec point (which previously wasn't validated)
siy
approved these changes
Apr 15, 2021
| @@ -70,7 +70,7 @@ public static ECKeyPair generateNew() { | |||
| ECPrivateKeyParameters privParams = (ECPrivateKeyParameters) keypair.getPrivate(); | |||
| ECPublicKeyParameters pubParams = (ECPublicKeyParameters) keypair.getPublic(); | |||
|
|
|||
| final ECPublicKey publicKey = ECPublicKey.fromBytes(pubParams.getQ().getEncoded(true)); | |||
| final ECPublicKey publicKey = new ECPublicKey(pubParams.getQ()); | |||
There was a problem hiding this comment.
I think it's better to have factory method for this rather than call constructor directly.
michalzajda
approved these changes
Apr 15, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Title
Use uncompressed representation for ECPublicKey equality
Description
Previously, if we initiated two instances of a public key of the same EC point with compressed and uncompressed byte representation (using
ECPublicKey.fromBytes) we would end up with two unequal objects. This PR changes it so that they're equal. Precisely: two public keys are equal if their uncompressed byte representation is equal. It also adds a validation that the bytes passed actually represent a valid point. This change also revealed that some classes were implicitly relying and being given a key with compressed bytes representation (RadixAddress for example).