Hotfix/fix hashing

radixdlt-core/radixdlt/src/main/java/com/radixdlt/sync/LocalSyncService.java

@@ -390,9 +390,22 @@ private boolean verifyResponse(SyncResponse syncResponse) {
 			.map(txn -> txn.getId().asHashCode())
 			.collect(ImmutableList.toImmutableList());
 
-		return this.validatorSetVerifier.verifyValidatorSet(syncResponse)
-			&& this.signaturesVerifier.verifyResponseSignatures(syncResponse)
-			&& this.accumulatorVerifier.verify(start, hashes, end);
+		if (!this.validatorSetVerifier.verifyValidatorSet(syncResponse)) {
+			log.warn("Invalid validator set");
+			return false;
+		}
+
+		if (!this.signaturesVerifier.verifyResponseSignatures(syncResponse)) {
+			log.warn("Invalid signatures");
+			return false;
+		}
+
+		if (!this.accumulatorVerifier.verify(start, hashes, end)) {
+			log.warn("Invalid accumulator");
+			return false;
+		}
+
+		return true;
 	}
 
 	private SyncState processSyncRequestTimeout(SyncingState currentState, SyncRequestTimeout syncRequestTimeout) {

radixdlt-java-common/src/main/java/com/radixdlt/crypto/HashUtils.java

@@ -135,11 +135,11 @@ public static int compare(HashCode fst, HashCode snd) {
 	 * @return calculated hash
 	 */
 	public static HashCode transactionIdHash(byte[] payload) {
-		return sha256(sha256(payload).asBytes());
+		return sha256(payload);
 	}
 
 	public static HashCode transactionIdHash(ByteBuffer buf) {
-		return sha256(sha256(buf.array(), buf.position(), buf.remaining()).asBytes());
+		return sha256(buf.array(), buf.position(), buf.remaining());
 	}
 
 	private HashUtils() {

radixdlt-java/radixdlt-java/src/main/java/com/radixdlt/client/core/atoms/Atoms.java

@@ -33,8 +33,6 @@ private Atoms() {
 
 	public static AID atomIdOf(Atom atom) {
 		var dson = Serialize.getInstance().toDson(atom, DsonOutput.Output.ALL);
-		var firstHash = HashUtils.sha256(dson);
-		var secondHash = HashUtils.sha256(firstHash.asBytes());
-		return AID.from(secondHash.asBytes());
+		return AID.from(HashUtils.sha256(dson).asBytes());
 	}
 }