-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure we test all builds/tests (doctests, some build configs) #1895
Conversation
Docker tags |
Benchmark for 1412be4Click to view benchmark
|
This speeds up the build and lets them compile with the test flag.
@@ -419,18 +419,17 @@ checksum = "baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd" | |||
|
|||
[[package]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated our version of chrono because of this error when compiling plotters: plotters-rs/plotters#624
An example of why using a lock file is very helpful 👍
Late to the party... But really impressive work! @dhedey 👏 |
Summary
Further tweaks off the back of #1891 to make our testing more comprehensive / reproducible. Just lots of tech debt which I've finally addressed and fixed up. Details below.
Details
test.sh
to make what it does more obvious / explicit./update-cargo-lock-minimally.sh
to fix all the Cargo lock files and lock templates, if you hit a problem caused by--locked
flags in CI.radix-engine-profiling
and add that build to CIradix-engine
dev dependencies in lots of test blueprint Cargo.tomls which caused errors when building them.resim/tests/resim.sh
which tried to output to a target directory which no longer existed (this fixes an error which got merged with arose from build: Use Cargo.lock for all crates #1891 when run on a new CI bot)Testing
CI tests pass. Doctests re-enabled.
Update Recommendations
None. For once :D