python rola implementation

[balda-rdx]

No description provided.

[0xOmarA]

Looks good overall but I think that there are some areas where changes are needed. Some of the most notable things that I think we should change are:

• Most functions either accept or return hex string and then immediately convert them into bytes to use them. I would recommend to stop using hex strings completely for function signatures and only use bytes to avoid redundant conversions between hex string and bytes.
• I would recommend we rely more on enums especially in areas where we know that the user can't provide us with arbitrary string or arbitrary input. An example of this is the challenge.proof.curve and the challenge.type. Also, depending on whether you think the gateway suggestion I provided is the way to go then network might also be an enum.
• Lets format this code base with a consistent formatter and check for it in CI. I recommend black because it's super simple and not-configurable.
• I believe that more unit tests are needed.

[balda-rdx]

Looks good overall but I think that there are some areas where changes are needed. Some of the most notable things that I think we should change are:

• Most functions either accept or return hex string and then immediately convert them into bytes to use them. I would recommend to stop using hex strings completely for function signatures and only use bytes to avoid redundant conversions between hex string and bytes.
• I would recommend we rely more on enums especially in areas where we know that the user can't provide us with arbitrary string or arbitrary input. An example of this is the challenge.proof.curve and the challenge.type. Also, depending on whether you think the gateway suggestion I provided is the way to go then network might also be an enum.
• Lets format this code base with a consistent formatter and check for it in CI. I recommend black because it's super simple and not-configurable.
• I believe that more unit tests are needed.

thanks for the feedback @0xOmarA . yes I've already added black, it is really nice and easy indeed.

Good call about the use of hex and bytes. will make the suggested change

I'm indeed adding more unit tests 👍

[0xOmarA]

Left a few comments on areas that I think we should change before we merge.

[0xOmarA]

Hey @balda-rdx, curious if this is ready for re review?

[balda-rdx]

Hey @balda-rdx, curious if this is ready for re review?

@0xOmarA yes yes 👍

[0xOmarA]

Fantastic, thanks @balda-rdx, will review in coming days.

[0xOmarA]

There's one comment that I left a ping on that we must address before we merge but aside from that I think this is good to go.