Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Target branch is not main, rather Ghenadies UniFFI branch
We really want this change on main too, but we expect to merge the UniFFI sep branch soon
Make unit test run in 80% faster (On my Mac Studio, now rung in 40s instead of 75 sec).
The slow test run in 1.3 sec instead of 5.3 sec.
The culprit was the manual look up in
sample_associated_mnemonic
usingif ==
comparision, instead of using a map structure.I profiled using
flamegraph
which is a great tool. It is a bit hard at first to understand. It is the width of the rows which matter, not the color nor does any horizintal position matter.See flramegraph file - this is run before this optimization
You need to boot your mac in Recovery Mode and disable SIP for
dtrace
to get flamegraph to work - follow this answer if you wanna try it yourself: https://stackoverflow.com/a/33584192