quick hover

[hrj]

For #17

API to get selectors that match a pseudo clause

I have created a new class called AnalyserUtil which is designed to be pure (state-less) class. The functions in this class are all declared static. There are only 4 public functions: getApplicableRules, getElementStyle, hasPseudoSelctor, hasPseudoSelectorForAncestor. The idea is that clients can use these functions efficiently, without necessarily storing / recreating an Analyser instance. They can choose to cache the intermediate results (such as the result of getApplicableRules).

This has been done without modifying the existing APIs and verifying that all unit tests pass. I have also tested everything in gngr.

Minor cleanup

• Fixed javadoc errors
• Simplified the function: SelectorImpl.getPseudoElement
• Updated version of unbescape to latest, 1.1.1

[radkovo]

Great, thanks for the refactoring. I like it very much. Merged.

[hrj]

Thanks for merging. There is a small bug that I just discovered now. I will send a PR soon.

Also, there is a possibility for optimisation. When finding applicable rules, all selectors get added. For example, when finding applicable selectors for a p element, if the CSS is:

div, p {
  color: red
}

then this rules gets added as it is. That is both, div and p selectors are retained.

It would be a nice optimisation if only the p selector was taken. I am trying to do this, but got stuck a little bit. Here's my working code:

final List<OrderedRule> nameRules = holder.get(HolderItem.ELEMENT, nameLC);
if (nameRules != null) {
    // Trying not to add all of them
    // candidates.addAll(nameRules);

    for (OrderedRule nr: nameRules) {
        ArrayList<CombinedSelector> matchingRules = new ArrayList<CombinedSelector>();
        for (CombinedSelector cs: nr.getRule().getSelectors()) {
            if (cs.getLastSelector().getElementName().equals(nameLC)) {
                matchingRules.add(cs);
            }
        }
        final int matchCount = matchingRules.size();
        RuleSetImpl ruleSet = new RuleSetImpl(matchingRules.toArray(new CombinedSelector[matchCount]));
        ruleSet.addAll(nr.getRule());
        candidates.add(new OrderedRule(ruleSet, nr.getOrder()));
    }
}

However, the line ruleSet.addAll() throws a runtime exception, because it is an abstract list. It looks like we need to create a rule factory for this, but that sounds like a big overhead. Do you have any ideas for this?

Thanks.

[hrj]

Btw, the bug is in the hasPseudoDeclaratorForAncestor() function. So you don't need to worry; It doesn't affect existing functionality.

[hrj]

Good news: There is no bug in jStyleParser code. I was using it slightly wrong in the browser. (When the mouse hovers out of an element, I was changing the match condition and then calling hasPseudoDeclaratorForAncestor, which was causing the match to fail. I am now calling it before changing the match condition and it works fine.)