[bug] ERROR about SQL with Keyword key

[andyli029]

radon

CREATE TABLE `wp_wpeditor_settings1` (
  `key` varchar(50) NOT NULL,
  `value` text NOT NULL,
  PRIMARY KEY (`key`)
) SINGLE

下发backend

create table `wp_wpeditor_settings1` (
	key varchar(50) not null,
	value text not null,
	primary key (key)
);

MySQL

mysql> create table `wp_wpeditor_settings1` (
    ->     key varchar(50) not null,
    ->     value text not null,
    ->     primary key (key)
    -> );
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'varchar(50) not null,
    value text not null,
    primary key (key)
)' at line 2

log

2019/09/19 17:02:23.475748 frm.go:39:    	 [INFO] 	frm.write.data[db:two, table:wp_wpeditor_settings1, shardType:SINGLE]
 2019/09/19 17:02:23.477557 execute.go:109:    	 [INFO] 	spanner.execute.ddl.query:create table wp_wpeditor_settings1 (
	`key` varchar(50) not null,
	`value` text not null,
	primary key (`key`)
) engine=InnoDB
 2019/09/19 17:02:23.479855 connection.go:206:    	 [ERROR] 	conn[127.0.0.1:3000].execute[create table `two`.`wp_wpeditor_settings1` (
	key varchar(50) not null,
	value text not null,
	primary key (key)
) engine=InnoDB].len[128].error:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'varchar(50) not null,
	value text not null,
	primary key (key)
) engine=InnoDB' at line 2 (errno 1064) (sqlstate 42000)
 2019/09/19 17:02:23.479908 txn.go:433:    	 [ERROR] 	txn.execute.on[127.0.0.1:3000].query[create table `two`.`wp_wpeditor_settings1` (
	key varchar(50) not null,
	value text not null,
	primary key (key)
) engine=InnoDB].error:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'varchar(50) not null,
	value text not null,
	primary key (key)
) engine=InnoDB' at line 2 (errno 1064) (sqlstate 42000)
 2019/09/19 17:02:23.480032 frm.go:53:    	 [WARNING] 	frm.remove.file[two].for.[db:wp_wpeditor_settings1, table:bin/radon-meta/two/wp_wpeditor_settings1.json]
 2019/09/19 17:02:23.480699 query.go:115:    	 [ERROR] 	proxy.DDL[CREATE TABLE `wp_wpeditor_settings1` (   `key` varchar(50) NOT NULL,   `value` text NOT NULL,   PRIMARY KEY (`key`) ) SINGLE].from.session[1].error:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'varchar(50) not null,
	value text not null,
	primary key (key)
) engine=InnoDB' at line 2 (errno 1064) (sqlstate 42000)
 2019/09/19 17:02:23.480746 server.go:244:    	 [ERROR] 	server.handle.query.from.session[1].error:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'varchar(50) not null,
	value text not null,
	primary key (key)
) engine=InnoDB' at line 2 (errno 1064) (sqlstate 42000).query[CREATE TABLE `wp_wpeditor_settings1` (   `key` varchar(50) NOT NULL,   `value` text NOT NULL,   PRIMARY KEY (`key`) ) SINGLE]

[hustjieke]

ACK.

[hustjieke]

Queto ` is removed here:
https://github.com/radondb/radon/blob/master/src/planner/ddl_plan.go#L140

	if node.Table.Qualifier.IsEmpty() {
		segTable = fmt.Sprintf("`%s`.`%s`", database, orgSegTable)
		rawQuery = strings.Replace(p.RawQuery, "`", "", -1)  <<<<---------
		// \b: https://www.regular-expressions.info/wordboundaries.html
		re, _ = regexp.Compile(fmt.Sprintf(`\b(%s)\b`, table))
	} else {
		segTable = fmt.Sprintf("`%s`.`%s`", database, orgSegTable)
		newTable := fmt.Sprintf("%s.%s", database, table)
		rawQuery = strings.Replace(p.RawQuery, "`", "", -1)<<<<---------
		re, _ = regexp.Compile(fmt.Sprintf(`\b(%s)\b`, newTable))
	}

[BohuTANG]

Ping @andyli029

[andyli029]

ack