Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] backendnum statistics error in radon slave #698

Closed
zhyass opened this issue Nov 5, 2020 · 0 comments
Closed

[bug] backendnum statistics error in radon slave #698

zhyass opened this issue Nov 5, 2020 · 0 comments
Assignees
@zhyass
Milestone
next

Comments

@zhyass
Copy link
Contributor

zhyass commented Nov 5, 2020 •
edited
Loading

The slave node of Radon will synchronize metadata from the master node. At this time, backend.json will be reloaded, causing backendnum to be counted repeatedly.

backend_number{instance="cln-h7eywl6v",job="radon",type="backend"}  46
backend_number{instance="cln-j6ktmwdo",job="radon",type="backend"} 2

We need set 0 before reload the backend config.
@zhyass zhyass added this to the next milestone Nov 5, 2020
@zhyass zhyass self-assigned this Nov 5, 2020
zhyass added a commit to zhyass/radon that referenced this issue Nov 5, 2020
@zhyass
*: fix the backendnum statistics error radondb#698
edd62cc 
[summary]
The slave node of Radon will synchronize metadata from the master node. At this time, backend.json will be reloaded, causing backendnum to be counted repeatedly.

Set 0 before reload the backend config.

[test case]
src/monitor/monitor_test.go

[patch codecov]
src/monitor/monitor.go 96.3%
src/backend/scatter.go 88.7%
BohuTANG added a commit that referenced this issue Nov 5, 2020
@BohuTANG
Merge pull request #699 from zhyass/feature_set
730c623 
*: fix the backendnum statistics error #698
@zhyass zhyass closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhyass zhyass

Labels
None yet
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@zhyass