sqlparser: support auto_increment option after engine define in ddl s… #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
=======================================
Coverage ? 89%
=======================================
Files ? 121
Lines ? 9538
Branches ? 0
=======================================
Hits ? 8500
Misses ? 693
Partials ? 345Continue to review full report at Codecov.
|
|
LGTM |
hustjieke
force-pushed
the
feature_support_auto_after_engine_#559
branch
from
31df63f to
dcc73d0
Compare
|
push update: add instructions about AUTO_INCREMENT table_option in doc radon_sql_support.md. |
|
Ping @andyli029 |
…tatement radondb#559 [summary] add a auto_increment option after engine, like: create table t(a int auto_increment key) engine=innodb auto_increment=1. [test case] src/vendor/github.com/xelabs/go-mysqlstack/ddl_test.go [patch codecov] vendor/github.com/xelabs/go-mysqlstack/sqlparser 0.049s coverage: 87.6% of statements
hustjieke
force-pushed
the
feature_support_auto_after_engine_#559
branch
from
dcc73d0 to
5c61911
Compare
|
push update: refresh code to resolve conflict on sql.go. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tatement #559
[summary]
add a auto_increment option after engine, like: create table t(a int
auto_increment key) engine=innodb auto_increment=1.
[test case]
src/vendor/github.com/xelabs/go-mysqlstack/ddl_test.go
[patch codecov]
vendor/github.com/xelabs/go-mysqlstack/sqlparser 0.049s coverage: 87.6% of statements