Add support for TPM SLB9670 module on RK3399 platform #385
+42
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadxaYuntian
requested changes
Dec 9, 2024
|
I refactored the overlay following to your indications. I hope it's ok, now. |
RadxaYuntian
requested changes
Dec 10, 2024
arch/arm64/boot/dts/rockchip/overlays/rk3399-spi1-cs1-slb9670.dts
Outdated
Show resolved
Hide resolved
arch/arm64/boot/dts/rockchip/overlays/rk3399-spi1-cs1-slb9670.dts
Outdated
Show resolved
Hide resolved
arch/arm64/boot/dts/rockchip/overlays/rk3399-spi1-cs1-slb9670.dts
Outdated
Show resolved
Hide resolved
arch/arm64/boot/dts/rockchip/overlays/rk3399-spi1-cs1-slb9670.dts
Outdated
Show resolved
Hide resolved
arch/arm64/boot/dts/rockchip/overlays/rk3399-spi1-cs1-slb9670.dts
Outdated
Show resolved
Hide resolved
arch/arm64/boot/dts/rockchip/overlays/rk3399-spi1-cs1-slb9670.dts
Outdated
Show resolved
Hide resolved
arch/arm64/boot/dts/rockchip/overlays/rk3399-spi1-cs1-slb9670.dts
Outdated
Show resolved
Hide resolved
arch/arm64/boot/dts/rockchip/overlays/rk3399-spi1-cs1-slb9670.dts
Outdated
Show resolved
Hide resolved
ehbello
force-pushed
the
tpm-slb9670
branch
2 times, most recently
from
08bfa16 to
f0722f8
Compare
|
I applied the implementation suggested by @CodeChenL at #385 (comment) and accordingly also renamed the file to I hope it is finally ok, now. |
CodeChenL
reviewed
Feb 11, 2025
RadxaYuntian
requested changes
Feb 11, 2025
arch/arm64/boot/dts/rockchip/overlays/rk3399-spi1-cs-gpio-slb9670.dts
Outdated
Show resolved
Hide resolved
Add support for TPM module SLB9670 using spi1-gpio on rk3399 Signed-off-by: Enrique Hernández Bello <ehbello@gmail.com>
RadxaYuntian
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces support for the Infineon SLB9670 Trusted Platform Module (TPM), which provides secure key storage and hardware random number generation (HWRNG). The implementation enables the TPM on the
spi1bus withCS1using a GPIO pin for RK3399-based systems, potentially extensible to other boards.Key Changes
Added the
rk3399-spi1-add-cs1.dtsoverlay to support multi-CS configuration on SPI1 (CS0 is used by the SPI-flash on some boards)Introduced the
tpm-slb9670.dtsoverlay to configure and activate the SLB9670 TPM using the new available CS1.Testing
The TPM functionality on SPI has been verified on a RockPi 4C using a GeeekPi TPM9670 Module (EP-0149) from 52pi.com, initially designed for the Raspberry Pi header.
Note: The Raspberry Pi header differs from RockPi one on PIN 26, which corresponds to
ADC_IN0with no CS functionality. Therefore, redirection or bridging to PIN 22 is required for proper operation.I hope you find this contribution helpful.
Feel free to provide feedback or suggest further improvements.