Skip to content

Commit

Permalink
can: mpc5xxx_can: check of_iomap return before use
Browse files Browse the repository at this point in the history
of_iomap() can return NULL so that return needs to be checked and NULL
treated as failure. While at it also take care of the missing
of_node_put() in the error path.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: commit afa17a5 ("net/can: add driver for mscan family & mpc52xx_mscan")
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Nicholas Mc Guire authored and marckleinebudde committed Jul 23, 2018
1 parent 393753b commit b5c1a23
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/net/can/mscan/mpc5xxx_can.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ static u32 mpc52xx_can_get_clock(struct platform_device *ofdev,
return 0;
}
cdm = of_iomap(np_cdm, 0);
if (!cdm) {
of_node_put(np_cdm);
dev_err(&ofdev->dev, "can't map clock node!\n");
return 0;
}

if (in_8(&cdm->ipb_clk_sel) & 0x1)
freq *= 2;
Expand Down

0 comments on commit b5c1a23

Please sign in to comment.