Refactor AST #4
Merged
Refactor AST #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
raf-nr
commented
Nov 5, 2024
raf-nr
commented
- Add new constructor for identifiers
- Rename typed pattern and type definitions' constructors
- Add a limit on function arguments (must have at least 1 argument)
- Add a limit on tuple size (must have at least 2 elements)
|
CI починим в другом PR |
ksenmel
reviewed
Nov 5, 2024
| @@ -2,30 +2,30 @@ | |||
|
|
|||
| (** SPDX-License-Identifier: LGPL-3.0-or-later *) | |||
|
|
|||
| type identifier = string [@@deriving show { with_path = false }] | |||
| type identifier = Id of string [@@deriving show { with_path = false }] | |||
There was a problem hiding this comment.
дело вкуса + потом красивее переиспользовать код. Вообщем тут причина - так красивее
|
|
||
| type constant = | ||
| | CInt of int (** -1, 0, 1, ... *) | ||
| | CBool of bool (** true, false *) | ||
| | CChar of char (** 'a', 'b', 'c', ... *) | ||
| | CString of string (** "Hello world!" *) | ||
| | CUnit of unit (** () *) |
There was a problem hiding this comment.
Unit внутри себя ничего не хранит, поэтому обычного конструктора (CUnit) без элементов внутри будет достаточно. В самом начале просто ошибся
| @@ -34,18 +34,18 @@ type pattern = | |||
| | PConst of constant (** Any constant: '1', 'true', etc *) | |||
| | PVar of identifier (** A variable pattern: 'x', 'y', etc *) | |||
| | POr of pattern * pattern (** 'P1 | P2' *) | |||
| | PTuple of pattern list (** Tuple of patterns: '(P1, P2, P3)' *) | |||
| | PTuple of pattern * pattern * pattern list (** Tuple of patterns: '(P1, P2, P3)' *) | |||
There was a problem hiding this comment.
Тут тоже не поняла, почему так
There was a problem hiding this comment.
В ocaml кортеж состоит минимум из 2 элементов. Подобной структурой в AST мы создаем некоторый инвариант, что у нас кортеж - хотя бы 2 элемента (pattern * pattern) + оставшиеся элементы если они остались
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.