Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse the pr merge title and enforce conventional commits format #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daniel1302
Copy link

@daniel1302 daniel1302 commented May 4, 2021

This PR allows to parse the PR title when PR is merged as merge commit.

PR merge commit looks like:

2a712b9cfd912f36b6f7f70d16b336575881881a
Merge pull request #6 from colegleason/add-q
fix(package.json): move q to dependancies since it is required to run
==END==

So We can shift first line of the body and use it as a subject.
Flag to enable this feature is --commit_body

There is also added flag --strict_conv_commits. If the flag is provided, commit messages must be in the format described in the Standard Document. If the commit message does not match the format, it is not assigned to the section.

There is example in Readme.

@daniel1302 daniel1302 changed the title Parse the PR merge title feat: parse the pr merge title May 4, 2021
@rafinskipg
Copy link
Owner

Hi @daniel1302 looks good. I don't know if there's any blocker to release this. I think is ok. Can you also add your name to the contributors in the README and some explanation of this behavior in the documentation?

@daniel1302
Copy link
Author

@rafinskipg I have added one more feature. And Description. If it is ok to merge it. I would be happy. I have added flags to provide backward-compatibility for people.

@daniel1302 daniel1302 changed the title feat: parse the pr merge title feat: parse the pr merge title and enforce conventional commits format May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants