Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a 'Data Analyst', I would like to only view sections that need submission #2217

Open
3 of 7 tasks
lilybl1 opened this issue Oct 27, 2022 · 12 comments · May be fixed by #3311
Open
3 of 7 tasks

As a 'Data Analyst', I would like to only view sections that need submission #2217

lilybl1 opened this issue Oct 27, 2022 · 12 comments · May be fixed by #3311
Assignees
Labels
a11y Accessibility/Section 508 dev frontend office hours Refined Ticket has been refined at the backlog refinement

Comments

@lilybl1
Copy link

lilybl1 commented Oct 27, 2022

Description:
As a 'Data Analyst', I would like to only view sections that I need to submit data files for so that I'm not having to waste time or worry about data files that do not apply to my STT.

We observed during our v2.0 pilot that certain STTs we held moderated sessions with did not necessarily know what to do with the Section 4 area as they did not have that data file to submit. The knowledge center does have a note about this as a stop gap.

Acceptance Criteria:

  • SSP/TANF radio button continues to drive updates to Reports section below search button
  • Users will not longer see all Sections 1-4 but instead headers based on backend models
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:

  • Render the frontend reports page based on backend's model STT.filenames.keys() (e.g. ['Active Case Data', 'Closed Case Data', 'Aggregate Data', 'Stratum Data'])
  • Ensure frontend unit tests are updated to account for this more dynamic shift for TANF, SSP, and Tribal
  • If necessary, ensure the backend filenames.keys are passed to frontend

11/1: Discussed that we would continue to keep the radio button for TANF and SSP to help focus the user on each type

Notes:
Scenario: TANF Data Files
Given the STT Data Analyst has been approved to submit certain TANF Data Files (Section 1, 2, 3 and/or 4)
When logged into TDP
Then display all applicable sections (Active, Closed, Aggregate and/or Stratum) that the STT Data Analyst has been approved to submit

image
https://www.figma.com/file/irgQPLTrajxCXNiYBTEnMV/TDP-Mockups-For-Feedback?node-id=7624%3A50249&t=XjNrtEH5J4odxe7L-1

Scenario: SSP Data Files
Given the STT Data Analyst has been approved to submit certain STT Data Files (Section 1, 2, 3 and/or 4)
When logged into TDP
Then display all applicable sections (Active, Closed, Aggregate and/or Stratum) that the STT Data Analyst has been approved to submit

@lilybl1
Copy link
Author

lilybl1 commented Nov 1, 2022

Discussed in Backlog Refinement that this ticket should be generic not specific to Section 4.

@lilybl1
Copy link
Author

lilybl1 commented Nov 1, 2022

@andrew-jameson Updated per our discussion - can we sync on the triggers for the other sections?

@lilybl1 lilybl1 changed the title [Dev-ready Design] Section 4 (Stratum) appears only for those STTs that have been approved to submit this data file [Dev-ready Design] Display only for those approved sections by STT to submit data files Nov 1, 2022
@stevenino
Copy link

To be re-scoped to include all data types.

@reitermb reitermb changed the title [Dev-ready Design] Display only for those approved sections by STT to submit data files [Dev] Display only for those approved sections by STT to submit data files Nov 8, 2022
@stevenino stevenino changed the title [Dev] Display only for those approved sections by STT to submit data files Display only for those approved sections by STT to submit data files Nov 8, 2022
@andrew-jameson andrew-jameson self-assigned this Nov 8, 2022
@stevenino stevenino added the Refined Ticket has been refined at the backlog refinement label Nov 8, 2022
@andrew-jameson
Copy link
Collaborator

Self note: Write dev-ready requirements for frontend to display "keys" from data/states.csv for example to no longer show "section 1", "section 2" but instead selectively show "active", "closed", "aggregate" based on what they are supposed to submit.

@andrew-jameson andrew-jameson removed their assignment Nov 16, 2022
@andrew-jameson andrew-jameson added frontend a11y Accessibility/Section 508 labels Nov 16, 2022
@andrew-jameson andrew-jameson changed the title Display only for those approved sections by STT to submit data files As a 'Data Analyst', I would like to only view sections that need submission Nov 16, 2022
@andrew-jameson
Copy link
Collaborator

@reitermb If you can find any figma mockups for this, please do add them under notes otherwise we will proceed as-is.

@reitermb
Copy link

@reitermb If you can find any figma mockups for this, please do add them under notes otherwise we will proceed as-is.

We didn't have any that were up to date, but I spun one up for the sake of illustration. cc @stevenino

@stevenino
Copy link

@andrew-jameson Are figma mockups required? I know we wanted them if they already existed but I didn't think we needed to make new ones if there were none.

@andrew-jameson
Copy link
Collaborator

@andrew-jameson Are figma mockups required? I know we wanted them if they already existed but I didn't think we needed to make new ones if there were none.

No, not required. Good to have, thanks for adding to description, @reitermb

@reitermb
Copy link

@andrew-jameson Are figma mockups required? I know we wanted them if they already existed but I didn't think we needed to make new ones if there were none.

Just wanted to note that this was ~a 30 second modification on existing figma assets so I figured I'd just go for it

@stevenino
Copy link

Perfect. Thank you!

@lhuxraft
Copy link
Collaborator

11/22: Almost ready for Raft review. Failing code coverage, adding more tests

@lhuxraft
Copy link
Collaborator

11/25: Demoed on office hours on Friday, made suggested changes.

@elipe17 elipe17 linked a pull request Nov 25, 2024 that will close this issue
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility/Section 508 dev frontend office hours Refined Ticket has been refined at the backlog refinement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants