Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend Dependency Update #2977

Draft
wants to merge 57 commits into
base: develop
Choose a base branch
from
Draft

Backend Dependency Update #2977

wants to merge 57 commits into from

Conversation

elipe17
Copy link

@elipe17 elipe17 commented May 7, 2024

Summary of Changes

Provide a brief summary of changes
Pull request closes #1647

How to Test

List the steps to test the PR
These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
cd tdrs-backend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d 
  1. Open http://localhost:3000/ and sign in.
  2. Proceed with functional tests as described herein.
  3. Test steps should be captured in the demo GIF(s) and/or screenshots below.

Demo GIF(s) and screenshots for testing procedure

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • [insert ACs here]
  • lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

@elipe17 elipe17 self-assigned this May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.59%. Comparing base (8f5a452) to head (0e612cc).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
tdrs-backend/tdpservice/users/models.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2977      +/-   ##
===========================================
- Coverage    91.59%   91.59%   -0.01%     
===========================================
  Files          297      297              
  Lines         8509     8508       -1     
  Branches       621      621              
===========================================
- Hits          7794     7793       -1     
  Misses         601      601              
  Partials       114      114              
Flag Coverage Δ
dev-backend 91.42% <87.50%> (-0.01%) ⬇️
dev-frontend 92.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tdrs-backend/tdpservice/core/filters.py 70.00% <100.00%> (ø)
...drs-backend/tdpservice/data_files/admin/filters.py 56.00% <100.00%> (ø)
tdrs-backend/tdpservice/email/email.py 100.00% <100.00%> (ø)
tdrs-backend/tdpservice/email/tasks.py 80.45% <100.00%> (-0.23%) ⬇️
tdrs-backend/tdpservice/parsers/row_schema.py 96.58% <100.00%> (ø)
...-backend/tdpservice/parsers/schema_defs/tanf/t6.py 100.00% <ø> (ø)
...d/tdpservice/parsers/schema_defs/tribal_tanf/t6.py 100.00% <ø> (ø)
tdrs-backend/tdpservice/settings/common.py 99.34% <100.00%> (ø)
tdrs-backend/tdpservice/users/models.py 91.57% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7247a50...0e612cc. Read the comment docs.

@elipe17
Copy link
Author

elipe17 commented May 8, 2024

@robgendron
Copy link

Almost complete.

@robgendron
Copy link

Aiming to bring it into the environment by end of week.

@robgendron
Copy link

Pulled into backlog until blocker is resolved - not templated for a few weeks.

@elipe17 elipe17 added Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI and removed Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI labels Oct 22, 2024
@elipe17
Copy link
Author

elipe17 commented Oct 22, 2024

Deployed to raft environment 10/22/2024 to do some preliminary testing. The frontend seems to have no issues at all. I am not seeing any errors in the console, can navigate to all pages, and can happily submit datafiles. However, when I go to the admin page to start playing around we start seeing lots of errors in the console with respect to static files. It seems the new settings for file backend stuff is not connecting properly.
Screenshot 2024-10-22 at 10 13 35 AM

@elipe17
Copy link
Author

elipe17 commented Oct 22, 2024

Seems like our backend cusstom storages are halfway working. When I submit a file I can subsequently re-download it from the admin console. But the static files backend still seems to be incorrectly configured.

@elipe17 elipe17 added Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI and removed Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI labels Oct 22, 2024
@elipe17
Copy link
Author

elipe17 commented Oct 22, 2024

Used the correct staticfiles backend storage mechanism and resolved all the errors and warnings on the admin page.

@elipe17 elipe17 force-pushed the backend-dep-update branch from c7597ab to e4f9614 Compare October 30, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPIKE] Investigate the effort involved in upgrading to django 4
2 participants