Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Validation Logic for TANF Active Case Items 27, 29, 26AIII, and 32D #3292

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

elipe17
Copy link

@elipe17 elipe17 commented Nov 20, 2024

Summary of Changes

How to Test

cd tdrs-frontend && docker-compose up
cd tdrs-backend && docker-compose up
  1. Open http://localhost:3000/ and sign in.
  2. Submit a TANF S1 file that has changed the appropriate items (27, 29, and 26AIII) to be zero
  3. Verify you do not get cat2 errors for the zero fields
  4. Submit a SSP S1 file that changes an M2 item 32D to zero
  5. Verify you do not get any cat2 errors for that field

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • Validator for Items 27, 29, 26AIII, and 32D are revised to allow 0 as an acceptable value.
  • Error message related to Items 27, 29, 26AIII, and 32D should be updated to reflect correct expected options.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

@elipe17 elipe17 added backend dev raft review This issue is ready for raft review labels Nov 20, 2024
@elipe17 elipe17 self-assigned this Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (dd5ea65) to head (a3a6919).
Report is 52 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3292   +/-   ##
========================================
  Coverage    91.48%   91.48%           
========================================
  Files          297      297           
  Lines         8433     8433           
  Branches       611      611           
========================================
  Hits          7715     7715           
  Misses         605      605           
  Partials       113      113           
Flag Coverage Δ
dev-backend 91.34% <ø> (ø)
dev-frontend 92.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s-backend/tdpservice/parsers/schema_defs/ssp/m2.py 100.00% <ø> (ø)
...-backend/tdpservice/parsers/schema_defs/tanf/t1.py 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5ea65...a3a6919. Read the comment docs.

@elipe17 elipe17 added QASP Review and removed raft review This issue is ready for raft review labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise Validation Logic for TANF Active Case Items 27, 29, 26AIII, and 32D
3 participants