-
-
Notifications
You must be signed in to change notification settings - Fork 33
bug: fix wrong date coming on the frontend #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughUpdated the Containers table rendering in Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
view/app/containers/components/table.tsx
(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
view/app/containers/components/table.tsx (1)
view/components/ui/table.tsx (1)
TableCell
(92-92)
🔇 Additional comments (2)
view/app/containers/components/table.tsx (2)
145-145
: LGTM! Correct colspan calculation.The colspan correctly accounts for the optional Actions column (7 columns when
onAction
is present, 6 otherwise), ensuring the empty state message spans all columns properly.
86-90
: Verifycontainer.created
format fornew Date
compatibility. TheIntl.DateTimeFormat
usage is correct, but ensurecontainer.created
is an ISO-8601 string or millisecond timestamp. If it’s a seconds-since-epoch value (as a string), convert it (new Date(Number(container.created) * 1000)
) before formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM. We will consider releasing this in coming release cycle.
Thank you @kushagra0902 for considering contributing to the project and look forward for more active participation and contribution.
Happy learning 💚 🙌🏻
#369
In the containers table on the frontend, date was coming up as 1 Jan irrespective of creation date despite of correct date coming from the backend. Also made container cell column position dynamic.
Summary by CodeRabbit
Refactor
Style