Removal of mpas_pool_get_array_gpu calls for 2 routines #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the mpas_pool_get_array_gpu function by mpas_pool_get_array for the routines solve_diagnostics and init_coupled_diagnostics. The _gpu calls has !$acc data copyin directives and it transfers the variables on to gpu. The two functions solve_diagnostics and init_coupled_ diagnostics functions are also called outside the time integration. The data copying is corrupting the GPU data later in the timestep. This results in NaNs.
mgduda
added a commit
that referenced
this pull request
Apr 11, 2018
This merge replaces the calls to the mpas_pool_get_array_gpu function with calls to mpas_pool_get_array for the routines solve_diagnostics and init_coupled_diagnostics. The gpu calls have !$acc data copyin directives and they transfer the variables on to gpu. The two functions solve_diagnostics and init_coupled_diagnostics are also called outside the time integration. The data copying was corrupting the GPU data later in the timestep, resulting in NaNs. * removal_of_getarray_gpu_call: Removal of mpas_get_array_gpu calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the mpas_pool_get_array_gpu function by mpas_pool_get_array
for the routines solve_diagnostics and init_coupled_diagnostics.
The gpu calls has !$acc data copyin directives and it transfers the
variables on to gpu. The two functions solve_diagnostics and init_coupled
diagnostics functions are also called outside the time integration. The
data copying is corrupting the GPU data later in the timestep.
This results in NaNs.