Remove all update directives #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the mpas_pool_get_array_gpu function by mpas_pool_get_array for the routines solve_diagnostics and init_coupled_diagnostics. The _gpu calls has !$acc data copyin directives and it transfers the variables on to gpu. The two functions solve_diagnostics and init_coupled_ diagnostics functions are also called outside the time integration. The data copying is corrupting the GPU data later in the timestep. This results in NaNs.
Removed the IfDef MPAS_OPENACC to make it work for GPUs. The code inside ifDef was not executed resulting in the compilation error. This code is necessary for assigning rank to GPU, when a single host has multiple GPU in it. And also I have removed the commented lines which are unnecessary.
Removed all update directives around the halo exchange and at the end of each subroutine. This is done to facilitate the new halo exchange code which is suitable for GPU communication.The update directives were used to communicate through CPU.
mgduda
suggested changes
Apr 11, 2018
There was a problem hiding this comment.
It looks like this PR is built on top of PR #18 and as such, this PR includes changes that must be modified in PR #18. Generally, PRs should be independent (i.e., not just build one on top of the other), so that changes to an earlier PR necessitate changes to all other PRs. Can you rebase the changes in this PR on the atmosphere/gpu branch, and not on PR #18 ?
|
Created a new pull request PR 24 for the above changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all update directives around the halo exchange and at the
end of each subroutine. This is done to facilitate the new halo
exchange code which is suitable for GPU communication.The update
directives were used to communicate through CPU.
This PR is dependent on PR 17 and PR18.
The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).
Enter a description of this PR. This should include why this PR was created, and what it does.
Testing and relations to other Pull Requests should be added as subsequent comments.
See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931