Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider warnings on multilayer leiden usage and low omega_end #10

Closed
ragibson opened this issue May 28, 2024 · 0 comments
Closed

Reconsider warnings on multilayer leiden usage and low omega_end #10

ragibson opened this issue May 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ragibson
Copy link
Owner

We currently warn on usage of multi-layer leiden since their package is not particularly optimized for that use case and is much slower than our unified louvain implementation tweaks. However, that implementation is long deprecated and my performance improvements to upstream leiden may have been enough to replace this warning with just a documentation note.

In contrast, there is a note in the documentation about omega_end being set too low in multi-layer optimization settings. This probably warrants a warning in the code itself if we detect it occurring (heuristically on the value of omega or explicitly on the returned omega estimates).

@ragibson ragibson added the enhancement New feature or request label May 28, 2024
ragibson added a commit that referenced this issue Jun 1, 2024
It is still extremely slow for large numbers of layers, but
remains arguably one of the most popular modularity optimization
algorithms.

See #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant