feat: expose serverStreamingCallable to save transformation #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulKQL
commented
Apr 30, 2020
Comment on lines
290
to
291
| private <ReqT, RowT> ServerStreamingCallable<ReadRowsRequest, RowT> createReadRowsRawCallable( | ||
| ServerStreamingCallSettings<ReqT, Row> readRowsSettings, RowAdapter<RowT> rowAdapter) { |
There was a problem hiding this comment.
Do you think is it acceptable for a private method to have two generic parameters but return the third class instead?
Because those generics classes would be only used for fetching the settings.
There was a problem hiding this comment.
Thanks a lot for your opinion!!!
dmitry-fa
reviewed
Apr 30, 2020
| * <li>Upon receiving the response stream, it will merge the {@link | ||
| * com.google.bigtable.v2.ReadRowsResponse.CellChunk}s in logical rows. The actual row | ||
| * implementation can be configured in by the {@code rowAdapter} parameter. | ||
| * <li>Retry/resume on failure. |
There was a problem hiding this comment.
be configured in by
->
be configured by
(3 times)
rahulKQL
force-pushed
the
readRowsCallableOp
branch
2 times, most recently
from
86cbd43 to
8cb4be2
Compare
…leStub This commit would enable the user to target the table using absolute resource name on each read request. Currently we expose `ServerStreamingCallable<Query, RowT>`, which does not have an option to provide different `app-profile-id` on each request.
rahulKQL
force-pushed
the
readRowsCallableOp
branch
from
8cb4be2 to
fb025ae
Compare
With this commit, the public createReadRowsCallable() would refer to single createReadRowsBaseCallable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Progress