-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dApp: blockchain progress for opening a channel #2136
Conversation
This event will be needed for keeping track of when a channel gets opened.
You modified |
Codecov Report
@@ Coverage Diff @@
## master #2136 +/- ##
==========================================
- Coverage 95.72% 95.64% -0.08%
==========================================
Files 160 159 -1
Lines 5967 5977 +10
Branches 1047 1052 +5
==========================================
+ Hits 5712 5717 +5
- Misses 194 197 +3
- Partials 61 63 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… notification Gets the values necessary for counting blocks from the channel open success event and passes them to a helper function for dispatching a notification whenever a channel open success event is registered.
One mutation for adding or updating a notification based on whether a notification is dispatched with an id that already exists in the notifications array.
Notification success now also takes in the values which were added when refactoring the store to enable updating of notifications.
Calling the getter for incrementing the id inside of the actions caused the id to be incremented even when new notifications were dispatched with the same id. To solve this we had to refactor and move everything to the mutations.
The NotificationCard component now displays the block count if the txConfirmationBlock is defined. Also, the NotificationArea component has been renamed to NotificationSnackbar since we are always refering to it as a snackbar.
Apart from fixing the broken tests I started with the tests for the newly added channel open notificaion, however it is currently not passing so I commented it out for now while working on somethin else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have done a lot of this PR together. At least the basic "design" and a lot of debugging. So I have not reviewed the code manually again. We agreed that all code parts that are not too nice here, are based on the current code structure which will become target of upcoming issues that should clean this up.
Thanks for all your hard work. 💪
I think this feature showed perfectly, that sometimes a feature might look small, but the current code structure does not support it. So first the structure needs to be adopted, to then make such feature easy to integrate. Though all the trouble we had for days with this feature reminded us of some parts of the code that are hard to work with and will need some attention.
PS: We agreed that this PR won't care about the code coverage. There are so far no tests for the |
Great and thank you @weilbith for your assistance in debugging and code design. |
Fixes #1941
Short description
Introduces notification for opening a channel with a block counter that counts until channel gets opened.
Definition of Done
Steps to manually test the change (dApp)