Enable parity plus Byzantium client version check #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banteg
reviewed
Oct 14, 2017
| major, minor, patch = [ | ||
| int(x) for x in re.search('//v(\d)\.(\d)\.(\d)', client_version).groups() | ||
| ] | ||
| if minor < 7 or (minor == 7 and patch < 6): |
There was a problem hiding this comment.
i think this would be much clearer if (major, minor, patch) < (1, 7, 6):
There was a problem hiding this comment.
Hey thanks, you are right! Tuple comparison would make this check much clearer.
banteg
reviewed
Oct 14, 2017
| int(x) for x in re.search('/v(\d)\.(\d)\.(\d)', client_version).groups() | ||
| ] | ||
| if minor < 7 or (minor == 7 and patch == 0): | ||
| print('You need Byzantium enabled geth. >= 1.7.1') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1078
With the release of parity 1.7.6, we have a byzantium enabled parity client and raiden should now be able to work with it!
This PR also adds a version check for geth too.