Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added py-spy and changed the stress script to use it #5729

Merged

Conversation

hackaugusto
Copy link
Contributor

Adds py-spy as a dev dependency and change the stress test to use it. This should be a more performant version since it is effectively a sampler profiler, while our current implementation is really a tracer.

@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #5729 into develop will increase coverage by 4.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #5729     +/-   ##
==========================================
+ Coverage    76.47%   80.77%   +4.3%     
==========================================
  Files          132      132             
  Lines        15279    15279             
  Branches      2336     2336             
==========================================
+ Hits         11684    12341    +657     
+ Misses        2923     2293    -630     
+ Partials       672      645     -27
Flag Coverage Δ
#integration 74.9% <ø> (+5.82%) ⬆️
#unit 55.57% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
raiden/transfer/state_change.py 97.9% <0%> (+0.41%) ⬆️
raiden/messages/transfers.py 83.95% <0%> (+0.53%) ⬆️
raiden/blockchain/events.py 96.47% <0%> (+0.7%) ⬆️
raiden/routing.py 86.44% <0%> (+0.84%) ⬆️
raiden/transfer/mediated_transfer/mediator.py 92.06% <0%> (+0.94%) ⬆️
raiden/transfer/channel.py 89.42% <0%> (+0.97%) ⬆️
raiden/network/proxies/user_deposit.py 43.61% <0%> (+1.06%) ⬆️
raiden/transfer/events.py 98.68% <0%> (+1.31%) ⬆️
raiden/transfer/mediated_transfer/target.py 98.56% <0%> (+1.43%) ⬆️
raiden/transfer/views.py 95.52% <0%> (+1.49%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66fecb2...026c1c5. Read the comment docs.

@hackaugusto hackaugusto force-pushed the add_pyspy_to_stresstest branch 2 times, most recently from 8b614c0 to 3a69362 Compare January 21, 2020 19:57
@karlb
Copy link
Contributor

karlb commented Jan 27, 2020

I liked how easy it was to enable profiling in any raiden instance with the old approach. With this approach we only get it for the stress test. Any reason for doing it differently, this time? Is it because you lack the nursery in the main raiden code?

@hackaugusto
Copy link
Contributor Author

Any reason for doing it differently, this time? Is it because you lack the nursery in the main raiden code?

You can get profiling information with py-spy just as easily:

https://github.com/benfred/py-spy#record

Copy link
Contributor

@karlb karlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me. I would just rename the output files to .svg instead of .data.

@hackaugusto hackaugusto merged commit 29cd116 into raiden-network:develop Jan 28, 2020
@hackaugusto hackaugusto deleted the add_pyspy_to_stresstest branch January 28, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants