-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added py-spy and changed the stress script to use it #5729
Added py-spy and changed the stress script to use it #5729
Conversation
e58b573
to
d77d965
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5729 +/- ##
==========================================
+ Coverage 76.47% 80.77% +4.3%
==========================================
Files 132 132
Lines 15279 15279
Branches 2336 2336
==========================================
+ Hits 11684 12341 +657
+ Misses 2923 2293 -630
+ Partials 672 645 -27
Continue to review full report at Codecov.
|
8b614c0
to
3a69362
Compare
I liked how easy it was to enable profiling in any raiden instance with the old approach. With this approach we only get it for the stress test. Any reason for doing it differently, this time? Is it because you lack the nursery in the main raiden code? |
You can get profiling information with py-spy just as easily: |
3a69362
to
026c1c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me. I would just rename the output files to .svg
instead of .data
.
Adds py-spy as a dev dependency and change the stress test to use it. This should be a more performant version since it is effectively a sampler profiler, while our current implementation is really a tracer.