Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect_new_paths in mdppathcollector #138

Open
Yuichi-Nakababayashi opened this issue Aug 1, 2021 · 0 comments
Open

collect_new_paths in mdppathcollector #138

Yuichi-Nakababayashi opened this issue Aug 1, 2021 · 0 comments

Comments

@Yuichi-Nakababayashi
Copy link

I'm using this repository in my research project, I appreciate this project.

I have a question about a function 'collect_nwe_paths' in MdpPathCollector.

I think the condition to break while loop (while num_steps_collected < num_steps:) is not

 if (path_len != max_path_length and not path["terminals"][-1] and discard_incomplete_paths):

but

 if (path_len != max_path_length_this_loop and not path["terminals"][-1] and discard_incomplete_paths):

as this if condition is to tell if collected path should be discarded.

Glad if you could give me a reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant