Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQL results different with the paper #172

Open
dssrgu opened this issue Jan 20, 2023 · 1 comment
Open

IQL results different with the paper #172

dssrgu opened this issue Jan 20, 2023 · 1 comment

Comments

@dssrgu
Copy link

dssrgu commented Jan 20, 2023

Hi,

The IQL results from this repo seem to differ from the original paper.

According to the README of the IQL example code here, IQL scores an average raw return of about 1500 on hopper-medium-expert with offline training:
https://github.com/rail-berkeley/rlkit/tree/master/examples/iql
image

However, the original paper notes that IQL scores 91.5 in normalized average return (which is about 2950 in raw return):
https://arxiv.org/pdf/2110.06169.pdf
image

Can you take a look at this and check what is causing the difference?

Thank you!

@anair13
Copy link
Contributor

anair13 commented Jun 17, 2024

Sorry for the late response, but the IQL experiments in the paper were run in jax and should be reproducible with the other repo: https://github.com/ikostrikov/implicit_q_learning

This reimplementation is pytorch is for convenience and likely has minor initialization differences etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants