Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#809 Guangzhou Metro 2024 facilities #855

Merged
merged 1 commit into from
Oct 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions public/images/facilities/airport_guangzhou.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions public/images/facilities/intercity_guangzhou.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions public/images/facilities/railway_guangzhou.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
26 changes: 16 additions & 10 deletions src/components/svgs/nodes/facilities.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,14 @@ export enum FacilitiesType {
GardensByTheBay = 'gardens_by_the_bay',
SingaporeFlyer = 'singapore_flyer',
Esplanade = 'esplanade',
QingdaoAirport = 'qingdao_airport',
QingdaoCoachStation = 'qingdao_coach_station',
QingdaoCruiseTerminal = 'qingdao_cruise_terminal',
QingdaoRailway = 'qingdao_railway',
QingdaoTram = 'qingdao_tram',
AirportQingdao = 'airport_qingdao',
CoachStationQingdao = 'coach_station_qingdao',
CruiseTerminalQingdao = 'cruise_terminal_qingdao',
RailwayQingdao = 'railway_qingdao',
TramQingdao = 'tram_qingdao',
AirportGuangzhou = 'airport_guangzhou',
RailwayGuangzhou = 'railway_guangzhou',
IntercityGuangzhou = 'intercity_guangzhou',
}

const Facilities = (props: NodeComponentProps<FacilitiesAttributes>) => {
Expand Down Expand Up @@ -126,11 +129,14 @@ const attrsComponent = (props: AttrsProps<FacilitiesAttributes>) => {
[FacilitiesType.GardensByTheBay]: 'Gardens by the Bay',
[FacilitiesType.SingaporeFlyer]: 'Singapore Flyer',
[FacilitiesType.Esplanade]: 'Esplanade',
[FacilitiesType.QingdaoAirport]: 'Airport Qingdao',
[FacilitiesType.QingdaoRailway]: 'Railway Qingdao',
[FacilitiesType.QingdaoCoachStation]: 'Coach Station Qingdao',
[FacilitiesType.QingdaoCruiseTerminal]: 'Cruise Terminal Qingdao',
[FacilitiesType.QingdaoTram]: 'Tram Qingdao',
[FacilitiesType.AirportQingdao]: 'Airport Qingdao',
[FacilitiesType.RailwayQingdao]: 'Railway Qingdao',
[FacilitiesType.CoachStationQingdao]: 'Coach Station Qingdao',
[FacilitiesType.CruiseTerminalQingdao]: 'Cruise Terminal Qingdao',
[FacilitiesType.TramQingdao]: 'Tram Qingdao',
[FacilitiesType.AirportGuangzhou]: 'Airport Guangzhou',
[FacilitiesType.RailwayGuangzhou]: 'Railway Guangzhou',
[FacilitiesType.IntercityGuangzhou]: 'Intercity Guangzhou',
},
onChange: val => {
attrs.type = val as FacilitiesType;
Expand Down
12 changes: 12 additions & 0 deletions src/util/save.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -497,4 +497,16 @@ describe('Unit tests for param upgrade function', () => {
'{"graph":{"options":{"type":"directed","multi":true,"allowSelfLoops":true},"attributes":{},"nodes":[],"edges":[]},"svgViewBoxZoom":100,"svgViewBoxMin":{"x":0,"y":0},"version":38}';
expect(newParam).toEqual(expectParam);
});

it('38 -> 39', () => {
// Bump save version to support Guangzhou 2024 facilities.
const oldParam =
'{"graph":{"options":{"type":"directed","multi":true,"allowSelfLoops":true},"attributes":{},"nodes":[],"edges":[]},"svgViewBoxZoom":100,"svgViewBoxMin":{"x":0,"y":0},"version":38}';
const newParam = UPGRADE_COLLECTION[38](oldParam);
const graph = new MultiDirectedGraph() as MultiDirectedGraph<NodeAttributes, EdgeAttributes, GraphAttributes>;
expect(() => graph.import(JSON.parse(newParam))).not.toThrow();
const expectParam =
'{"graph":{"options":{"type":"directed","multi":true,"allowSelfLoops":true},"attributes":{},"nodes":[],"edges":[]},"svgViewBoxZoom":100,"svgViewBoxMin":{"x":0,"y":0},"version":39}';
expect(newParam).toEqual(expectParam);
});
});
5 changes: 4 additions & 1 deletion src/util/save.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export interface RMPSave {
svgViewBoxMin: { x: number; y: number };
}

export const CURRENT_VERSION = 38;
export const CURRENT_VERSION = 39;

/**
* Load the tutorial.
Expand Down Expand Up @@ -453,4 +453,7 @@ export const UPGRADE_COLLECTION: { [version: number]: (param: string) => string
37: param =>
// Bump save version to support Shanghai 2024 facilities.
JSON.stringify({ ...JSON.parse(param), version: 38 }),
38: param =>
// Bump save version to support Guangzhou 2024 facilities.
JSON.stringify({ ...JSON.parse(param), version: 39 }),
};
Loading