Grape Support

[bf4]

https://github.com/jrhe/grape-active_model_serializers/blob/ca9c8faaa99727300ff21419aa20471ac27eed42/lib/grape-active_model_serializers/formatter.rb#L15-L25

        def fetch_serializer(resource, env)
          endpoint = env['api.endpoint']
          options = build_options_from_endpoint(endpoint)

          serializer = options.fetch(:serializer, ActiveModel::Serializer.serializer_for(resource))
          return nil unless serializer

          options[:scope] = endpoint unless options.key?(:scope)
          # ensure we have an root to fallback on
          options[:resource_name] = default_root(endpoint) if resource.respond_to?(:to_ary)
          serializer.new(resource, options.merge(other_options(env)))
        end

which uses serializer = ActiveModel::Serializer.serializer_for(resource)).new(resource, options) which is (somewhat intentionally) not supported in 0.10.

I'd be in favor of adding a grape serializer something or other (grape users can help here).

In the meantime, this may work

Grape::Formatter::ActiveModelSerializers.module_eval do # might be instance_eval
      class << self
        def fetch_serializer(resource, env)
          endpoint = env['api.endpoint']
          options = build_options_from_endpoint(endpoint)

           serializer = options.fetch(:serializer, ActiveModel::Serializer.serializer_for(resource))
-          return nil unless serializer


          options[:scope] = endpoint unless options.key?(:scope)
          # ensure we have an root to fallback on
          options[:resource_name] = default_root(endpoint) if resource.respond_to?(:to_ary)
+        serialization_options = options.merge(adapter: :json, serializer: merge!(other_options(env))).serializer) 
+          ActiveModel::SerializableResource.new(resource, serialization_options) # assuming you want json, I don't know which adapter to use

-          serializer.new(resource, options.merge(other_options(env)))
        end
  end
end

Related issues

• No serializer found for resource #1250 (comment)
• embed_in_root_key breaks on multiple objects #705
• "not opened for reading" on ams > 0.9.3 #1038 (comment)
• "not opened for reading" on ams > 0.9.3 #1038

[bf4]

@rails-api/ams

[bf4]

ref: #1268

[joaomdmoura]

Should we put it somewhere else, like docs? @bf4
It's kind confusing IMO

[hut8]

Hey @bf4 -- thanks for documenting this. I'm a bit lost on this line:

serialization_options = options.merge(adapter: :json, serializer: merge!(other_options(env))).serializer) 

Looks like unbalanced parenthesis and merge! isn't defined on that context.... what should this be?

[bf4]

I just wrote it up, untested, so do what makes sense? There's also a grape pr

B mobile phone

On Oct 23, 2015, at 3:17 PM, Liam notifications@github.com wrote:

Hey @bf4 -- thanks for documenting this. I'm a bit lost on this line:

serialization_options = options.merge(adapter: :json, serializer: merge!(other_options(env))).serializer)
Looks like unbalanced parenthesis and merge! isn't defined on that context.... what should this be?

—
Reply to this email directly or view it on GitHub.

[bf4]

Implementation PR is in #1273

[bf4]

Updated, is #1336