Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveSupport::Notifications Support #1319

Closed
wagenet opened this issue Nov 5, 2015 · 3 comments
Closed

ActiveSupport::Notifications Support #1319

wagenet opened this issue Nov 5, 2015 · 3 comments

Comments

@wagenet
Copy link
Contributor

wagenet commented Nov 5, 2015

Is there any objection to adding ActiveSupport::Notifications instrumentation? It looks like it existed briefly in 0.9 but is no longer in master. I'd be happy to help with this for use in Skylight.
@beauby
Copy link
Contributor

beauby commented Nov 5, 2015

No objection. Possibly related to #1291.

@bf4
Copy link
Member

bf4 commented Nov 5, 2015

Sure @wagenet you wanna make a PR?

@wagenet
Copy link
Contributor Author

wagenet commented Nov 5, 2015

Looks like #1291 would actually address my use case. Missed it in earlier searching.

@wagenet wagenet closed this as completed Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wagenet @bf4 @beauby