Bug fix for ArraySerializer json_key #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the resource is a zero result query,
i.e. post_comments = PostComment.where("1=0")
the json_key will become 'postcomments' rather than 'post_comments'.
Using 'underscore' instead of 'downcase' fixes the error.
|
Awesome @jiajiawang! |
|
Sure
|
test json key when resource is empty
|
Great! LGTM, I'm merging it. |
joaomdmoura
added a commit
that referenced
this pull request
Jul 16, 2015
Bug fix for ArraySerializer json_key
pranavpr
added a commit
to Poncho-Box8/active_model_serializers
that referenced
this pull request
Aug 11, 2015
| @@ -38,6 +38,17 @@ def test_meta_and_meta_key_attr_readers | |||
| assert_equal @serializer.meta, "the meta" | |||
| assert_equal @serializer.meta_key, "the meta key" | |||
| end | |||
|
|
|||
| def test_json_key_when_resource_is_empty | |||
| Array.class_eval do | |||
There was a problem hiding this comment.
looks like it's trying to be a fake AR Relation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the resource is a zero result query,
i.e. post_comments = PostComment.where("1=0")
the json_key will become 'postcomments' rather than 'post_comments'.
Using 'underscore' instead of 'downcase' fixes the error.