Support proper parse the file name in mingw platform. #1014

Eric-Guo · 2015-07-17T12:58:59Z

Original regexp will failed the file name parse in Windows.

Example link: http://rubular.com/r/QRJfZ11BZL

bf4 · 2015-07-17T20:00:53Z

Please add a test using the example from your regex link

regex = /^[^:]+/
caller_line = "c:/git/emberjs/ember-crm-backend/app/serializers/lead_serializer.rb:1:in `<top (required)>'"
regex.match(caller_line) #=> #<MatchData "c">
caller_line = "c/git/emberjs/ember-crm-backend/app/serializers/lead_serializer.rb:1:in `<top (required)>'"
regex.match(caller_line) #=>  #<MatchData "c/git/emberjs/ember-crm-backend/app/serializers/lead_serializer.rb">

Also, while in here, it might be worth changing the File.open(name).read to File.read so that we don't create a lot of unclosed filehandles

bf4 · 2015-07-17T20:06:18Z

Looks like if you change the regex to use a lookahead it works fine \A\S+(?=:\d+:in)

CALLER_FILE = /
  /A # start of string
  \S+ # one or more non-spaces
  (?= # stop previous match when
    :\d+:in # a colon is followed by one or more digits 
               # followed by a colon followed by in
   ) 
/x

Eric-Guo · 2015-07-17T22:48:50Z

@bf4 I just change code to using only CALLER_FILE pattern, also using File.read.

it's a bit too hard for me to add a testing, so I just write commit comments instead. 😄

bf4 · 2015-07-17T22:55:32Z

lib/active_model/serializer.rb

-      serializer_file = File.open(caller.first[/^[^:]+/])
-      base._cache_digest = Digest::MD5.hexdigest(serializer_file.read)
+      serializer_file_path = caller.first[/\A\S+(?=:\d+:in)/]
+      base._cache_digest = Digest::MD5.hexdigest(File.read(serializer_file_path))
    end


needs a test!

😈 (yay!)

OK, be seriously, there is already testing existing, but the problem is if you not running in Windows, c:/git won't return to you from ruby side, so it's really hard to write a test to testing that case in Linux.

@bf4 So if you really care about Windows user, just merge this PR and I will propose another to fix testing suite in windows, because even current testing case is not all pass in windows...

if you really care about Windows user

Of course I care. No reason not add a regression test

Also, I'm not a collab so I can't merge it sorry :)

@kurko @joaomdmoura Let's see if we can set up an appveyor account to test on windows. I know RSpec does this and it works pretty well.

using the appveyor is right, since current testing case running in windows can already cover this problem.

But seems its complex and really necessory? Just relay on me should enough, I will definitely working on windows and always report/fix issue if found.

As Windows user, really don't expect we will be regarded as first class support tie like Mac/Linux in Rails ecosystem. 😭

joaomdmoura · 2015-07-19T03:12:47Z

Hey ppl. First of all @Eric-Guo we care about all users.
I'm already setting an appveyor account in order to improve our stack.
@bf4 is right, I'd love to have as many tests as possible for the right things.
There is no reason to rush here, you can keep using your fork while we set up appveyor and write a test for it.

bf4 · 2015-08-04T02:10:31Z

@Eric-Guo you still interested in writing tests for this?
@joaomdmoura any progress in setting up appveyor? https://mattbrictson.com/how-to-test-ruby-windows

bf4 · 2015-08-04T02:14:02Z

I'm happy to pair or pull in your commit

Eric-Guo · 2015-08-04T22:29:13Z

Sorry, seems after code rebase, some of the comments lost, the existing serialization_scope_name_test can already cover this change, the only problem is caller will return 'c:\git\path' only in Windows, so you can not catch it if you running test suite in Linux/Mac. 😅

@bf4

So we will got full file path instead of only c if caller.first is: c:/git/emberjs/ember-crm-backend/app/serializers/lead_serializer.rb:1:in `<top (required)>' CALLER_FILE = / /A # start of string \S+ # one or more non-spaces (?= # stop previous match when :\d+:in # a colon is followed by one or more digits # followed by a colon followed by in ) /x credit from https://gist.github.com/mikezter/540132 and @bf4

bf4 · 2015-08-18T21:34:05Z

@Eric-Guo I made a PR into your master branch with tests. Would you be willing to merge that in so we can merge this? Eric-Guo#1

Test caller line parsing and digesting

Eric-Guo · 2015-08-19T05:35:08Z

@bf4 thanks, I running in Windows and new add testing pass after add tzdata, only one testing failed.

  1) Failure:
SerializerGeneratorTest#test_with_no_attributes_does_not_add_extra_space [c:/git/emberjs/active_model_serializers/test/g
enerators/serializer_generator_test.rb:48]:
Expected /\n\nend/ to not match "\nclass AccountSerializer < ActiveModel::Serializer\n  attributes :id\n\nend\n\n".

182 runs, 273 assertions, 1 failures, 0 errors, 0 skips

Eric-Guo · 2015-08-19T06:11:20Z

@joaomdmoura appreciate could merge this now?

bf4 · 2015-08-19T18:24:19Z

Gemfile

@@ -15,3 +15,6 @@ if version == "master"
 else
  gem "rails", "~> #{version}.0"
 end
+
+# Windows does not include zoneinfo files, so bundle the tzinfo-data gem
+gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]


jruby doesn't either? or jruby on windows?

@bf4 it's just copy from Railties app template, not known jruby status.

Oh, then that works for me. Since we don't have a Gemfile.lock in version control, we don't even need to edit that.

bf4 · 2015-08-19T18:25:57Z

@Eric-Guo you're saying you have one test failing on windows test/generators/serializer_generator_test.rb:48 (something about matching line endings in the generator) but you're ok merging it?

Eric-Guo · 2015-08-20T06:32:43Z

@joaomdmoura @bf4 serializer_generator_test also fixed, because in windows, using \r\n instead of \n.

bf4 · 2015-08-20T14:23:24Z

test/generators/serializer_generator_test.rb

+        assert_no_match /\r\n\r\nend/, content
+      else
+        assert_no_match /\n\nend/, content
+      end


@Eric-Guo you can just assert_no_match /\r?\n\r?\nend/, content

Can not write like assert_no_match /\r?\n\r?\nend/, content, because will cause below error.

1) Failure: SerializerGeneratorTest#test_with_no_attributes_does_not_add_extra_space [c:/git/emberjs/active_model_serializers/test/g enerators/serializer_generator_test.rb:48]: Expected /\r?\n\r?\nend/ to not match "\nclass AccountSerializer < ActiveModel::Serializer\n attributes :id\n\nend\n\n"

Or if you want to get wild

# record_separator = $-0 == $/ assert_no_match /#{record_separator}#{record_separator}end/, content

$-0 are also '\n', same as unix, maybe ruby bug?

@bf4

thanks @bf4 give many help and suggestion

joaomdmoura · 2015-08-21T04:52:04Z

FYI: #1066

bf4 · 2015-08-21T05:46:27Z

Awesome!

@bf4

thanks @bf4 give many help and suggestion, original PR rails-api#1014

Eric-Guo · 2015-08-21T13:12:30Z

Now PR to appveyor branch at #1071

rails-api/active_model_serializers#1014

Eric-Guo added a commit to Eric-Guo/ember-crm-backend that referenced this pull request Jul 17, 2015

Now can running in 0.10.0 after proposed below PR.

787696b

rails-api/active_model_serializers#1014

Eric-Guo force-pushed the master branch from 342901f to 151301c Compare July 17, 2015 22:44

Eric-Guo changed the title ~~Using parse_caller to support proper parse the file name in mingw platform.~~ To support proper parse the file name in mingw platform. Jul 17, 2015

Eric-Guo changed the title ~~To support proper parse the file name in mingw platform.~~ Support proper parse the file name in mingw platform. Jul 17, 2015

bf4 reviewed Jul 17, 2015
View reviewed changes

joaomdmoura added the V: 0.10.x label Jul 19, 2015

Eric-Guo force-pushed the master branch 3 times, most recently from 58dc096 to 7e5e2b4 Compare July 24, 2015 12:19

Eric-Guo force-pushed the master branch 3 times, most recently from c5cee81 to 5f131b8 Compare August 2, 2015 08:36

Eric-Guo force-pushed the master branch 3 times, most recently from 8c471cd to f319d40 Compare August 13, 2015 01:33

Eric-Guo force-pushed the master branch from f319d40 to f477666 Compare August 15, 2015 05:57

Eric-Guo force-pushed the master branch from f477666 to f93a7e8 Compare August 18, 2015 01:54

Test caller line parsing and digesting

215fb85

bf4 mentioned this pull request Aug 18, 2015

Test caller line parsing and digesting Eric-Guo/active_model_serializers#1

Merged

Merge pull request #1 from bf4/parse_windows_paths

90bff2f

Test caller line parsing and digesting

bf4 reviewed Aug 19, 2015
View reviewed changes

bf4 reviewed Aug 20, 2015
View reviewed changes

Eric-Guo force-pushed the master branch from 4e108f0 to 2daca84 Compare August 21, 2015 02:50

Make testing suite running and pass in Windows

4459652

thanks @bf4 give many help and suggestion

Eric-Guo force-pushed the master branch from 2daca84 to 4459652 Compare August 21, 2015 03:02

Eric-Guo added a commit to Eric-Guo/active_model_serializers that referenced this pull request Aug 21, 2015

Make testing suite running and pass in Windows

30463f8

thanks @bf4 give many help and suggestion, original PR rails-api#1014

Eric-Guo mentioned this pull request Aug 21, 2015

Make testing suite running and pass in Windows #1071

Merged

Eric-Guo closed this Aug 21, 2015

Eric-Guo added a commit to Eric-Guo/ember-crm-backend that referenced this pull request Aug 29, 2015

Now can running in 0.10.0 after proposed below PR.

5dae74a

rails-api/active_model_serializers#1014

Eric-Guo mentioned this pull request Feb 26, 2016

Make plugin :tmp_restart behavior correct in Windows. puma/puma#905

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support proper parse the file name in mingw platform. #1014

Support proper parse the file name in mingw platform. #1014

Eric-Guo commented Jul 17, 2015

bf4 commented Jul 17, 2015

bf4 commented Jul 17, 2015

Eric-Guo commented Jul 17, 2015

bf4 Jul 17, 2015

bf4 Jul 17, 2015

Eric-Guo Jul 17, 2015

Eric-Guo Jul 17, 2015

bf4 Jul 18, 2015

Eric-Guo Jul 18, 2015

joaomdmoura commented Jul 19, 2015

bf4 commented Aug 4, 2015

bf4 commented Aug 4, 2015

Eric-Guo commented Aug 4, 2015

bf4 commented Aug 18, 2015

Eric-Guo commented Aug 19, 2015

Eric-Guo commented Aug 19, 2015

bf4 Aug 19, 2015

Eric-Guo Aug 20, 2015

bf4 Aug 20, 2015

bf4 commented Aug 19, 2015

Eric-Guo commented Aug 20, 2015

bf4 Aug 20, 2015

Eric-Guo Aug 21, 2015

bf4 Aug 21, 2015

Eric-Guo Aug 21, 2015

joaomdmoura commented Aug 21, 2015

bf4 commented Aug 21, 2015

Eric-Guo commented Aug 21, 2015

Support proper parse the file name in mingw platform. #1014

Support proper parse the file name in mingw platform. #1014

Conversation

Eric-Guo commented Jul 17, 2015

bf4 commented Jul 17, 2015

bf4 commented Jul 17, 2015

Eric-Guo commented Jul 17, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joaomdmoura commented Jul 19, 2015

bf4 commented Aug 4, 2015

bf4 commented Aug 4, 2015

Eric-Guo commented Aug 4, 2015

bf4 commented Aug 18, 2015

Eric-Guo commented Aug 19, 2015

Eric-Guo commented Aug 19, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bf4 commented Aug 19, 2015

Eric-Guo commented Aug 20, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joaomdmoura commented Aug 21, 2015

bf4 commented Aug 21, 2015

Eric-Guo commented Aug 21, 2015