Update fragment cache to support namespaced objects #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM, a great catch |
joaomdmoura
added a commit
that referenced
this pull request
Aug 18, 2015
Update fragment cache to support namespaced objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to name the cached and uncached serializers didn't take into account namespaces in object names. This would exhibit itself with an error like:
NameError: wrong constant name Spam::unrelatedLinkCachedSerializer.The use of
.capitalizedidn't take all the scenarios into account. Since the name being passed in is already from an existing class name (serializer.object.class.name) there is no need to capitalize the value, instead I just did a simple string replacement for::namespace delimiters into_s.