Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage; account for no artifacts on CI #1069

Merged
merged 2 commits into from
Sep 6, 2015
Merged

Add test coverage; account for no artifacts on CI #1069

merged 2 commits into from
Sep 6, 2015

Conversation

bf4
Copy link
Member

@bf4 bf4 commented Aug 21, 2015

Requires #1109

@bf4 bf4 force-pushed the coverage branch 2 times, most recently from 9b4a65b to f40bd38 Compare August 21, 2015 08:12
@bf4
Copy link
Member Author

bf4 commented Aug 24, 2015

Failures were in jruby and rbx because they do coverage differently and had a lower minimum coverage... I'm considering lowering it overall, or perhaps having an implementation-specific coverage minimum? In any case, the PR works

@joaomdmoura
Copy link
Member

Despite of being simple the .simplecov looks a little bit tricky to me.
I'm okay with lowering it overall, I think the goal here is to give us the bigger picture and keep track of it.

@bf4
Copy link
Member Author

bf4 commented Aug 26, 2015

Yup. Will do

@bf4 bf4 force-pushed the coverage branch 3 times, most recently from aa06f14 to 4404a17 Compare August 27, 2015 06:28
@bf4
Copy link
Member Author

bf4 commented Aug 27, 2015

@joaomdmoura Improved, the one failure is rbx, just needs to be restarted

This was referenced Aug 28, 2015
Closed
Merged
@joaomdmoura
Copy link
Member

restarting

bf4 added 2 commits September 6, 2015 09:19
@bf4
Add test coverage; account for no artifacts on CI
94469be 
Drop coverage a bit for JRuby and Rubinius because they
don't generate the same Coverage as CRuby
@bf4
Add codeclimate test reporter (CI only)
c401722 
requires repo admin to add
CODECLIMATE_REPO_TOKEN
to the CI env
@bf4
Copy link
Member Author

bf4 commented Sep 6, 2015

Rebased and rubocoped

joaomdmoura added a commit that referenced this pull request Sep 6, 2015
@joaomdmoura
Merge pull request #1069 from bf4/coverage
6799453 
Add test coverage; account for no artifacts on CI
@joaomdmoura joaomdmoura merged commit 6799453 into rails-api:master Sep 6, 2015
@bf4 bf4 deleted the coverage branch September 7, 2015 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bf4 @joaomdmoura