Add configuration option to set resource type to singular/plural #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The proposed config key is |
|
Cool @beauby Thanks you so much, I'm merging this 😄 |
joaomdmoura
added a commit
that referenced
this pull request
Aug 28, 2015
Add configuration option to set resource type to singular/plural
|
Oh, Could you please also write some docs to it onto our new docs and maybe mention it shortly on README? |
| with_jsonapi_resource_type :singular do | ||
| serializer = CommentSerializer.new(@comment) | ||
| adapter = ActiveModel::Serializer::Adapter::JsonApi.new(serializer) | ||
| ActionController::Base.cache_store.clear |
There was a problem hiding this comment.
Indeed, we could use SerializableResource through all those serializer + adapter in the tests, glad that yyou pointed that out@bf4. @beauby could you make a PR updating it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSONAPI spec (http://jsonapi.org/format/#document-resource-object-identification) does not specify whether the
typeshould be singular or plural. By default, AMS makes it plural, while some client-side libraries default to singular. This PR adds a configuration option to globally set it to plural or singular. (c.f. #1080)