[WIP] Fix extra db hit with belongs_to association #1118
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1100,
belongs_to
associations currently load the record instead of using theassociation_name_id
attribute when available (i.e. with ActiveRecord).The explicit calls have been fixed, but the way things are, the records are actually loaded when building the associations anyways. A satisfying fix would be to lazify that part.
This PR is built on top of #1103 (which was initially intended to provide an easy way to fix #1100).