[WIP] Add config option to globally format JSONAPI type.

lib/active_model/serializer/adapter/json_api.rb

@@ -55,10 +55,11 @@ def fragment_cache(cached_hash, non_cached_hash)
         private
 
         def resource_identifier_type_for(serializer)
-          if ActiveModel::Serializer.config.jsonapi_resource_type == :singular
-            serializer.object.class.model_name.singular
+          if serializer.respond_to?(:type)
+            serializer.type
           else
-            serializer.object.class.model_name.plural
+            type = serializer.object.class.model_name.singular
+            ActiveModel::Serializer.config.jsonapi_type_formatter.call(type)
           end
         end
 

lib/active_model/serializer/configuration.rb

@@ -7,7 +7,7 @@ module Configuration
       included do |base|
         base.config.array_serializer = ActiveModel::Serializer::ArraySerializer
         base.config.adapter = :flatten_json
-        base.config.jsonapi_resource_type = :plural
+        base.config.jsonapi_type_formatter = -> (type) { type.pluralize }
       end
     end
   end

test/adapter/json_api/json_api_test.rb

@@ -31,6 +31,17 @@ def test_custom_keys
             site: { data: { type: 'blogs', id: '1' } }
             }, adapter.serializable_hash[:data][:relationships])
         end
+
+        def test_override_type
+          post_override_serializer = Class.new(PostSerializer) do
+            def type
+              'override'
+            end
+          end
+          hash = ActiveModel::SerializableResource.new(@post, adapter: :json_api, serializer: post_override_serializer).serializable_hash
+
+          assert_equal('override', hash[:data][:type])
+        end
       end
     end
   end

test/adapter/json_api/resource_type_config_test.rb

@@ -27,17 +27,17 @@ def setup
             @author.posts = []
           end
 
-          def with_jsonapi_resource_type type
-            old_type = ActiveModel::Serializer.config.jsonapi_resource_type
-            ActiveModel::Serializer.config.jsonapi_resource_type = type
+          def with_jsonapi_type_formatter formatter
+            old_formatter = ActiveModel::Serializer.config.jsonapi_type_formatter
+            ActiveModel::Serializer.config.jsonapi_type_formatter = formatter
             yield
           ensure
-            ActiveModel::Serializer.config.jsonapi_resource_type = old_type
+            ActiveModel::Serializer.config.jsonapi_type_formatter = old_formatter
           end
 
           def test_config_plural
             with_adapter :json_api do
-              with_jsonapi_resource_type :plural do
+              with_jsonapi_type_formatter -> (type) { type.pluralize } do
                 hash = ActiveModel::SerializableResource.new(@comment).serializable_hash
                 assert_equal('comments', hash[:data][:type])
               end
@@ -46,7 +46,7 @@ def test_config_plural
 
           def test_config_singular
             with_adapter :json_api do
-              with_jsonapi_resource_type :singular do
+              with_jsonapi_type_formatter -> (type) { type.singularize } do
                 hash = ActiveModel::SerializableResource.new(@comment).serializable_hash
                 assert_equal('comment', hash[:data][:type])
               end