Remove Adapter autoloads in favor of require #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
force-pushed
the
remove_adapter_autoloads
branch
3 times, most recently
from
f2fcdb7 to
46104e4
Compare
| @@ -1,4 +1,7 @@ | |||
| class ActiveModel::Serializer::Adapter::Json < ActiveModel::Serializer::Adapter | |||
| module ActiveModel | |||
There was a problem hiding this comment.
I remember a commit going the other way a couple weeks ago. Ha
|
👍 |
bf4
force-pushed
the
remove_adapter_autoloads
branch
from
46104e4 to
0c85b61
Compare
Adapters must be eager loaded to ensure they are defined before they are used as namespacing. rails-api@cf6a074#diff-41f2b3509d33e1c65bb70ee0ec7a2eea
bf4
force-pushed
the
remove_adapter_autoloads
branch
from
0c85b61 to
ad2ca3b
Compare
|
@bf4 Glad to see we can keep the nested structure now that the autoloads are removed. Two wins for the price of one. :) |
|
This is good, and @bf4 that is one crazy detailed commit message. thanks! |
NullVoxPopuli
added a commit
that referenced
this pull request
Sep 18, 2015
Remove Adapter autoloads in favor of require
bf4
added a commit
to bf4/active_model_serializers
that referenced
this pull request
Sep 20, 2015
Breaking change: - Adapters now inherit Adapter::Base - 'Adapter' is now a module, no longer a class Why? - using a class as a namespace that you also inherit from is complicated and circular at time i.e. buggy (see rails-api#1177) - The class methods on Adapter aren't necessarily related to the instance methods, they're more Adapter functions - named `Base` because it's a Rails-ism - It helps to isolate and highlight what the Adapter interface actually is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapters must be eager loaded to ensure they are defined
before they are used as namespacing.
cf6a074#diff-41f2b3509d33e1c65bb70ee0ec7a2eea
Follows #1171