Add support for toplevel JSON API links. #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| require 'set' | |||
| module ActiveModel | |||
| class SerializableResource | |||
| ADAPTER_OPTION_KEYS = Set.new([:include, :fields, :adapter, :meta, :meta_key]) | |||
| ADAPTER_OPTION_KEYS = Set.new([:include, :fields, :adapter, :meta, :meta_key, :links]) | |||
There was a problem hiding this comment.
nice! shouldn't this integrate with existing code such as pagination links?
There was a problem hiding this comment.
Not really, pagination is automagically added anyways. I'm up for any suggestion though.
There was a problem hiding this comment.
but would both work well together? What do you think about adding a test covering it? 😄
There was a problem hiding this comment.
Yes, the pagination stuff just updates the links.
|
👍 |
|
Just one small comments, would be nice to have this test IMO. Other then this it LGTM |
|
LGTM then, merging it. |
joaomdmoura
added a commit
that referenced
this pull request
Oct 10, 2015
Add support for toplevel JSON API links.
leandrocp
added a commit
to leandrocp/active_model_serializers
that referenced
this pull request
Dec 23, 2015
leandrocp
added a commit
to leandrocp/active_model_serializers
that referenced
this pull request
Dec 23, 2015
update according rubocop rules
leandrocp
added a commit
to leandrocp/active_model_serializers
that referenced
this pull request
Feb 3, 2016
update according rubocop rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an adapter option: